Add options to always approve write and execute operations #1

stea9499 · 2024-11-01T20:49:21Z

Description

Add setting to always approve write and execute operations.

Related Issues

N/A

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Other

Screenshots/How Has This Been Tested?

New settings UI:

Example task which doesn't prompt for write or execute permissions:

mrubens

Awesome! 🚀

ellipsis-dev

❌ Changes requested. Reviewed everything up to 3c8a9c0 in 11 minutes and 23 seconds

More details

Looked at 963 lines of code in 10 files
Skipped 1 files when reviewing.
Skipped posting 6 drafted comments based on config settings.

1. src/core/Cline.ts:1119

Draft comment:
Consider refactoring the repeated logic for checking alwaysAllowWrite and alwaysAllowExecute before calling askApproval into a separate function to improve code readability and maintainability. This pattern is repeated in several places, such as lines 1119, 1527, and 1510.
Reason this comment was not posted:
Confidence changes required: 50%
The code in Cline.ts has multiple instances where the askApproval function is used to check for user approval before proceeding with certain actions. However, the logic for checking alwaysAllowWrite and alwaysAllowExecute is repeated multiple times. This can be refactored to improve code readability and maintainability.

2. src/core/Cline.ts:1507

Draft comment:
Consider refactoring the repeated logic for handling alwaysAllowWrite, alwaysAllowExecute, and alwaysAllowReadOnly flags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well.
Reason this comment was not posted:
Marked as duplicate.

3. src/core/Cline.ts:1116

Draft comment:
Consider refactoring the repeated logic for handling alwaysAllowWrite, alwaysAllowExecute, and alwaysAllowReadOnly flags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well.
Reason this comment was not posted:
Marked as duplicate.

4. src/core/Cline.ts:1093

Draft comment:
Consider refactoring the repeated logic for handling alwaysAllowWrite, alwaysAllowExecute, and alwaysAllowReadOnly flags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well.
Reason this comment was not posted:
Marked as duplicate.

5. src/core/Cline.ts:110

Draft comment:
Consider refactoring the repeated logic for handling alwaysAllowWrite, alwaysAllowExecute, and alwaysAllowReadOnly flags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well.
Reason this comment was not posted:
Marked as duplicate.

6. src/core/Cline.ts:96

Draft comment:
Consider refactoring the repeated logic for handling alwaysAllowWrite, alwaysAllowExecute, and alwaysAllowReadOnly flags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well.
Reason this comment was not posted:
Marked as duplicate.

Workflow ID: wflow_Cbit47NFizGGxsdB

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

ellipsis-dev · 2024-11-01T21:00:50Z

src/core/Cline.ts

 							path: getReadablePath(cwd, removeClosingTag("path", relPath)),
 						}
 						try {
 							if (block.partial) {


Consider refactoring the repeated logic for handling alwaysAllowWrite, alwaysAllowExecute, and alwaysAllowReadOnly flags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well.

ellipsis-dev · 2024-11-01T21:00:50Z

src/core/webview/ClineProvider.ts

 	| "vertexRegion"
 	| "lastShownAnnouncementId"
 	| "customInstructions"
 	| "alwaysAllowReadOnly"


The constant alwaysAllowWrite is already defined in the codebase, making this a duplicate. Please use the existing definition in src/core/Cline.ts or src/core/webview/ClineProvider.ts. Avoid redundancy.

constant alwaysAllowWrite (Cline.ts)

constant alwaysAllowWrite (ClineProvider.ts)

Syncing sbc-roo-code main branch

Update from upstream

Update README.md

… tools Fixes issue where isWriteProtected was incorrectly passed as the partial flag to task.ask(), causing "Current ask promise was ignored (#1)" error. Both tools now use the askApproval wrapper function which correctly handles the parameter ordering, passing undefined for progressStatus and isWriteProtected as the fourth parameter. Fixes #7648

… tools (#7649) Fixes issue where isWriteProtected was incorrectly passed as the partial flag to task.ask(), causing "Current ask promise was ignored (#1)" error. Both tools now use the askApproval wrapper function which correctly handles the parameter ordering, passing undefined for progressStatus and isWriteProtected as the fourth parameter. Fixes #7648 Co-authored-by: Roo Code <[email protected]>

… tools (RooCodeInc#7649) Fixes issue where isWriteProtected was incorrectly passed as the partial flag to task.ask(), causing "Current ask promise was ignored (RooCodeInc#1)" error. Both tools now use the askApproval wrapper function which correctly handles the parameter ordering, passing undefined for progressStatus and isWriteProtected as the fourth parameter. Fixes RooCodeInc#7648 Co-authored-by: Roo Code <[email protected]>

resync

核心实现: - 修复 MessageIndexManager 返回类型，返回完整 HistoricalMessage[] - 修复 content 字段类型处理，支持字符串类型 - 增强 getStats() 方法，添加 totalConversations, totalTokens, nextGlobalIndex - 添加完整的单元测试覆盖 (17个测试用例全部通过) 测试覆盖: ✅ MessageIndexManager 单元测试 - 消息存储和索引分配 - Token估算 - 对话隔离 - 索引检索 - 统计信息 - 重置和边界情况验收测试通过: ✅ pnpm lint ✅ pnpm check-types ✅ pnpm build ✅ pnpm vsix 实现状态: ✅ 1. 逻辑已完整接入主程序 (ClineProvider → Task → attemptApiRequest) ✅ 2. 严格按照6步流程实现 (用户输入→裁判→专家→汇总→大模型) ✅ 3. UI已可视化 (消息索引号显示 RooCodeInc#1, RooCodeInc#2, RooCodeInc#3...) ✅ 4. 有单元测试验收 (MessageIndexManager.test.ts) 基于需求文档: docs/user-requirement-intelligent-context-system.md 实现计划: docs/intelligent-context-implementation-plan.md

Add options to always approve write and execute operations

3c8a9c0

mrubens approved these changes Nov 1, 2024

View reviewed changes

Ellipsis config

e2fb6b2

ellipsis-dev bot reviewed Nov 1, 2024

View reviewed changes

stea9499 merged commit 9ff9e6f into main Nov 1, 2024

lloydchang mentioned this pull request Nov 27, 2024

feat(core, shared, webview-ui): add options alwaysAllowWrite, alwaysAllowExecute and alwaysAllowBrowser cline/cline#784

Closed

shaybc mentioned this pull request Mar 5, 2025

subtasks alpha version (still in development) #1123

Merged

7 tasks

mrubens pushed a commit that referenced this pull request Mar 5, 2025

Merge pull request #1 from RooVetGit/main

a8d1fbb

Syncing sbc-roo-code main branch

mrubens pushed a commit that referenced this pull request Mar 11, 2025

Merge pull request #1 from cannuri/update-from-upstream

58532bc

Update from upstream

mrubens pushed a commit that referenced this pull request Mar 15, 2025

Merge pull request #1 from benzntech/benzntech-patch-1

44e3088

Update README.md

thebobbyboy420 mentioned this pull request Mar 22, 2025

Linux Terminal Shell Integration Not Working #1663

Closed

jtgsystems mentioned this pull request Apr 4, 2025

v3.11.5 #2283

Merged

henrikmcgee mentioned this pull request Apr 12, 2025

MCP: LLMs unable to properly escape JSON passed to MCP #2549

Closed

ewheelerinc mentioned this pull request Apr 16, 2025

Fix Terminal Carriage Return Handling for Correct Progress Bar Display #2562

Merged

XD1amond mentioned this pull request May 14, 2025

.roostats #3358

Closed

4 tasks

axmo mentioned this pull request Jun 4, 2025

VSCode LM Tools Integration #3811

Closed

4 tasks

HahaBill mentioned this pull request Jul 8, 2025

feat: Adding more settings and control over Gemini #4895

Closed

23 tasks

roomote pushed a commit that referenced this pull request Jul 8, 2025

Merge pull request #1 from RooVetGit/cte/modernize

6feaf74

taylorwilsdon mentioned this pull request Jul 20, 2025

[MCP] Add Google Workspace MCP to Roo Marketplace #5988

Closed

1 task

sjf126 mentioned this pull request Jul 22, 2025

feat: add moonshot provider #5869

Closed

6 tasks

Honga1 mentioned this pull request Jul 28, 2025

[feat] Add ability to queue chat message while AI is taking turn. #6287

Closed

4 tasks

roomote bot mentioned this pull request Aug 11, 2025

feat: add taskCommandExecuted event to track command execution results #6375

Closed

kristian-nst mentioned this pull request Aug 13, 2025

Add "Current Editor Context" to @ context menu #4141

Closed

4 tasks

3C0D mentioned this pull request Aug 27, 2025

Critical User Experience Issues with Roo #7438

Closed

hannesrudolph mentioned this pull request Sep 4, 2025

Bug: insert_content passes isWriteProtected as the partial flag, causing ‘Current ask promise was ignored’ #7648

Closed

roomote bot mentioned this pull request Sep 4, 2025

fix: use askApproval wrapper in insert_content and search_and_replace tools #7649

Merged

roomote bot mentioned this pull request Sep 11, 2025

feat(web): update homepage headline and tagline for remote control capabilities #7911

Merged

hannesrudolph mentioned this pull request Sep 16, 2025

[BUG] Intermittent “Current ask promise was ignored (#1)” with multi-file diff #8046

Open

roomote bot mentioned this pull request Sep 16, 2025

fix: resolve 'Current ask promise was ignored' error in multi-file diffs #8048

Closed

Mirrowel mentioned this pull request Sep 21, 2025

[ENHANCEMENT] Github Actions Bot #8202

Closed

2 tasks

hannesrudolph mentioned this pull request Oct 6, 2025

fix: implement non-destructive condense with metadata tracking #8513

Closed

roomote bot pushed a commit that referenced this pull request Oct 7, 2025

Merge pull request #1 from RooCodeInc/main

1694bcd

resync

This was referenced Oct 20, 2025

feat: gracefully handle removed models in UI #7419

Open

feat: add Gemini provider support for image generation #7945

Closed

Change the way that uploaded images are shown; remove base64 strings (Gray Screen Fix) #8225

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add options to always approve write and execute operations #1

Add options to always approve write and execute operations #1

Uh oh!

stea9499 commented Nov 1, 2024 •

edited

Loading

Uh oh!

mrubens left a comment

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

ellipsis-dev bot Nov 1, 2024

Uh oh!

ellipsis-dev bot Nov 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add options to always approve write and execute operations #1

Add options to always approve write and execute operations #1

Uh oh!

Conversation

stea9499 commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Type of Change

Screenshots/How Has This Been Tested?

Uh oh!

mrubens left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Nov 1, 2024

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Nov 1, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stea9499 commented Nov 1, 2024 •

edited

Loading