Skip to content

Conversation

@CellenLee
Copy link

@CellenLee CellenLee commented Jul 18, 2025

Related GitHub Issue

Closes: #586

Roo Code Task Context (Optional)

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

image

Documentation Updates

Additional Notes

Get in Touch


Important

Add Moonshot provider with handler, model definitions, UI integration, and tests.

  • Provider Addition:
    • Add moonshot to providerNames in provider-settings.ts.
    • Add moonshotSchema to providerSettingsSchemaDiscriminated and providerSettingsSchema in provider-settings.ts.
    • Add moonshotApiKey to SECRET_STATE_KEYS in global-settings.ts.
  • Handler Implementation:
    • Implement MoonshotHandler in moonshot.ts extending OpenAiHandler.
    • Add MoonshotHandler to buildApiHandler() in index.ts.
  • Model Definitions:
    • Define moonshotModels and moonshotDefaultModelId in moonshot.ts.
    • Add moonshotModels to MODELS_BY_PROVIDER in constants.ts.
  • UI Integration:
    • Add Moonshot component in Moonshot.tsx for settings UI.
    • Include Moonshot in ApiOptions.tsx and providers/index.ts.
  • Testing:
    • Add tests for MoonshotHandler in moonshot.spec.ts.
    • Update checkExistApiConfig.spec.ts to include moonshotApiKey.

This description was created by Ellipsis for 21d839e. You can customize this summary. It will automatically update as commits are pushed.

@CellenLee CellenLee requested review from cte, jr and mrubens as code owners July 18, 2025 04:28
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jul 18, 2025
@CellenLee CellenLee force-pushed the feat/moonshot-provider branch from 21d839e to dd55cb2 Compare July 18, 2025 04:30
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 18, 2025
@CellenLee CellenLee force-pushed the feat/moonshot-provider branch from dd55cb2 to 16117bc Compare July 18, 2025 05:15
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 18, 2025
@CellenLee CellenLee force-pushed the feat/moonshot-provider branch from 16117bc to ef9e6f3 Compare July 18, 2025 11:47
@daniel-lxs
Copy link
Member

Thank you @CellenLee for taking the time and implementing this, according to https://platform.moonshot.ai/docs/api/chat#public-service-address it seems like moonshot is already OpenAI compatible which means it can be used on Roo Code already.

Unless adding a new provider gives user additional benefits we usually don't add new providers that are OpenAI compatible already.

I'll close the PR but please feel free to let me know if there's additional benefits to having this provider added.

@daniel-lxs daniel-lxs closed this Jul 18, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 18, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 18, 2025
@sjf126
Copy link

sjf126 commented Jul 22, 2025

@daniel-lxs hi,We’re Moonshot AI, a startup from China building open, powerful, affordable LLMs for real-world use.
Our latest model, Kimi K2, supports 128K context, strong reasoning, and tool use. It’s currently the #1 open model on LMArena, featured in Nature, and handles 10B+ tokens/day on OpenRouter.

@CellenLee is our colleague. We’re big fans of RooCode, so we submitted this pull request.

We’d like to discuss with you the possibility of having our name, Moonshot, displayed in the same manner as DeepSeek.

we sincerely appreciate your time and consideration.

@mrubens
Copy link
Collaborator

mrubens commented Jul 22, 2025

@daniel-lxs hi,We’re Moonshot AI, a startup from China building open, powerful, affordable LLMs for real-world use. Our latest model, Kimi K2, supports 128K context, strong reasoning, and tool use. It’s currently the #1 open model on LMArena, featured in Nature, and handles 10B+ tokens/day on OpenRouter.

@CellenLee is our colleague. We’re big fans of RooCode, so we submitted this pull request.

We’d like to discuss with you the possibility of having our name, Moonshot, displayed in the same manner as DeepSeek.

we sincerely appreciate your time and consideration.

Hi @sjf126 and @CellenLee, I just saw this - would be happy to discuss more. We're big fans of Moonshot and Kimi as well, amazing work!

@mrubens
Copy link
Collaborator

mrubens commented Jul 22, 2025

I couldn't figure out how to reopen this so I merged #6046 instead. Thank you for the contribution!

@sjf126
Copy link

sjf126 commented Jul 24, 2025

@mrubens thank you!If there are new features later, we can collaborate to make more user-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants