feat: gracefully handle removed models in UI #7419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
- Show removed models in dropdown with '(unavailable)' label - Allow users to keep selected model even if removed from catalog - Clear removed models when switching providers - Add comprehensive test coverage for removed model scenarios - Add internationalization support for unavailable model label
hannesrudolph
force-pushed
the
feat/graceful-removed-models
branch
from
88c576a to
931db0f
Compare
Code Review Summary✅ No issues found - The implementation is clean and follows best practices. Review CompletedI've thoroughly reviewed this PR and found no bugs, security issues, or breaking changes. The implementation correctly:
The existing bot review comments (#1-#5) are style suggestions rather than critical issues. The code is ready for merge. Latest Commit Review (3889f6a)Reviewed the latest commit that removes the deprecated |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| description: | ||
| "A stealth reasoning model that is blazing fast and excels at agentic coding, accessible for free through Roo Code Cloud for a limited time. (Note: prompts and completions are logged by the model creator and used to improve the model.)", | ||
| }, | ||
| } as const satisfies Record<string, ModelInfo> |
There was a problem hiding this comment.
Changing type from Record<RooModelId, ModelInfo> to Record<string, ModelInfo> weakens type safety. If this is intended for flexibility, please add a clarifying comment.
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements graceful handling for models that have been removed from the catalog but are still selected in user configurations.
Changes
Behavior
When a model is removed from the catalog but still selected:
When switching providers:
Testing
All tests pass successfully:
Related Issues
Similar to #7392 but focused on graceful degradation rather than hiding providers.
Important
Enhances UI to handle removed models gracefully, adds internationalization for 'unavailable' label, and includes tests for robustness.
ApiOptions.tsx.ApiOptions.tsx.settings.jsonfiles.ApiOptions.spec.tsx.roo/sonictoroo.ts.This description was created by
for 3889f6a. You can customize this summary. It will automatically update as commits are pushed.