fix(fuselage): InputBox not stretching to the maximum available width - #2043
Closed
nazabucciarelli wants to merge 3 commits into
Closed
fix(fuselage): InputBox not stretching to the maximum available width#2043nazabucciarelli wants to merge 3 commits into
nazabucciarelli wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 731d8e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Author
|
We decided to fix it on the main repo, as the defined css |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
InputBox, and everything built on it (TextInput,UrlInput,EmailInput,NumberInput,TelephoneInput,TextAreaInput, etc.) collapses to itsmin-widthinstead of filling the available space when it is rendered as a direct child of a flex‑column container (e.g. a fuselageField, which isdisplay: flex; flex-direction: column; align-items: stretch) rather than inside aFieldRow.Root cause: v0.79.1 (#2024) added
width: 0to the shared.rcx-input-boxrule. A definitewidthdisables the cross‑axisstretchof a flex column item, so the input stops growing to the container width and falls back tomin-width: 8rem. In v0.79.0 and earlier the rule had nowidth, so it stretched correctly.Fix: Use a main‑axis‑only basis instead of a definite width:
Where it shows: in Rocket.Chat admin settings, every
relativeUrlsetting (e.g. the OAuth "Callback URL" fields) renders a readonlyUrlInputdirectly inside aField, and appears collapsed to ~128px with the URL truncated, while sibling text/secret fields (which sit inside aFieldRow) look fine.width: 0breaksInputBoxfor any addon‑less input rendered in a stretch (column/block) container, which is a valid usage. TherelativeUrlsetting (the one used inapps/meteor/server/settings/oauth.ts) is just the first place it became visible:TextInput,EmailInput, etc. collapse identically there, they are the same component with a differenttype. Fixing it in Rocket.Chat main repo would patch one symptom and leave the latent bug for every other current and future consumer.Issue(s)
CORE-2348 [Regression] OAuth callback URL fields render too narrow in admin settings
Further comments