regression: RelativeUrlSettingInput not stretching filling the available width - #41105
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
|
| Layer / File(s) | Summary |
|---|---|
Wrap UrlInput in FieldRow apps/meteor/client/views/admin/settings/Setting/inputs/RelativeUrlSettingInput.tsx |
UrlInput is now nested inside a second FieldRow within the Field, separate from the existing label/reset FieldRow. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Suggested labels
type: bug
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly describes the main regression and the affected setting component. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Warning
Review ran into problems
🔥 Problems
Errors were encountered while retrieving linked issues.
Errors (1)
- CORE-2348: Request failed with status code 401
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.6.0 #41105 +/- ##
================================================
Coverage ? 70.17%
================================================
Files ? 3371
Lines ? 130421
Branches ? 22629
================================================
Hits ? 91517
Misses ? 35582
Partials ? 3322
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Root cause: v0.79.1 (RocketChat/fuselage#2024) added width: 0 to the shared .rcx-input-box rule. A definite width disables the cross‑axis stretch of a flex column item, so the input stops growing to the container width and falls back to min-width: 8rem. In v0.79.0 and earlier the rule had no width, so it stretched correctly.
Where it shows: in Rocket.Chat admin settings, relativeUrl settings (e.g. the OAuth "Callback URL" fields) render a readonly UrlInput directly inside a Field, and appears collapsed to ~128px with the URL truncated, while sibling text/secret fields (which sit inside a FieldRow) look fine.
Suggested fix: Wrapping the
<UrlInput>component within a<FieldRow>component, as with every other settingIssue(s)
CORE-2348 [Regression] OAuth callback URL fields render too narrow in admin settings
Steps to test or reproduce
Further comments
Summary by CodeRabbit