regression: unresolved `@rocket.chat/string-helpers` import breaks Omnichannel queue side panel by abhinavkrin · Pull Request #41816 · RocketChat/Rocket.Chat

abhinavkrin · 2026-08-18T13:12:53Z

Proposed changes (including videos or screenshots)

InquireSidePanelItem imports escapeHTML from @rocket.chat/string-helpers, a package that no longer exists in the monorepo and is not a dependency of apps/meteor. This points the import at nothing, so the Omnichannel queue side panel items break at runtime.

Two PRs combined to produce this:

chore: drop @rocket.chat/string-helpers in favor of @rocket.chat/tools #41763 (742009a091) dropped the @rocket.chat/string-helpers package in favor of @rocket.chat/tools, which is where escapeHTML lives now.
fix: special characters not escaped in Omnichannel queue side panel message preview #41595 (b2c16d5842) added the escapeHTML import while still pointing at @rocket.chat/string-helpers. The import was valid when that branch was written, but chore: drop @rocket.chat/string-helpers in favor of @rocket.chat/tools #41763 landed first and fix: special characters not escaped in Omnichannel queue side panel message preview #41595 merged without picking it up, so develop ended up importing a deleted package.

The Meteor bundler surfaces it as an unresolved module during the build:

Unable to resolve some modules:

  "@rocket.chat/string-helpers" in
  apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx
  (web.browser)

This PR repoints the import to @rocket.chat/tools, which is already a workspace dependency of apps/meteor and exports the same escapeHTML (packages/tools/src/escapeHTML.ts). It is the module every other escapeHTML call site in the repo uses, so this only aligns the one straggler. No behavior change beyond restoring the escaping that #41595 intended.

No changeset: the breakage exists only on develop and was never released, so there is nothing to tell end users about.

Issue(s)

Regression from #41595, caused by the package removal in #41763.

Steps to test or reproduce

Check out develop at b2c16d5842 or later and build the Meteor app. Note the Unable to resolve some modules: "@rocket.chat/string-helpers" warning.
Enable Omnichannel and turn on the side panel / queue view, then have an incoming inquiry whose last message contains special characters, for example <b>bold</b> & "quoted".
Open the Omnichannel queue side panel and look at the inquiry item's message preview.
Expected result: the side panel renders without errors and the preview shows the literal text <b>bold</b> & "quoted" rather than crashing or rendering markup.

Further comments

escapeHTML moved in #41763; the dangling import arrived in #41595.

Summary by CodeRabbit

Refactor
- Updated internal HTML escaping utility usage without changing visible functionality.

…nichannel queue side panel Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>

dionisio-bot · 2026-08-18T13:12:57Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2026-08-18T13:12:59Z

⚠️ No Changeset found

Latest commit: 5b88cc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-08-18T13:13:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c2106718-4fa9-477c-b648-7785368f9c74

📥 Commits

Reviewing files that changed from the base of the PR and between eb6eccc and 5b88cc2.

📒 Files selected for processing (1)

apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx

Included review availability: Your plan includes up to 10 reviews per rolling hour; 8 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (9)

GitHub Check: 🔎 Code Check / Code Lint
GitHub Check: 🔨 Test Storybook / Test Storybook
GitHub Check: 🔨 Test Unit / Unit Tests
GitHub Check: 🔎 Code Check / TypeScript
GitHub Check: 📦 Meteor Build (coverage)
GitHub Check: cubic · AI code reviewer
GitHub Check: Hacktron Security Check
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx

apps/meteor/**

📄 CodeRabbit inference engine (CLAUDE.md)

The main Rocket.Chat Meteor application resides in apps/meteor/; place its application code there rather than in other monorepo areas.

Files:

apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx

🧠 Learnings (2)

📚 Learning: 2026-03-27T14:52:56.865Z

Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.

Applied to files:

apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx

📚 Learning: 2026-05-06T12:21:44.083Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.

Applied to files:

apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx

🔇 Additional comments (1)

apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx (1)

3-3: LGTM!

Walkthrough

The change updates the escapeHTML import in the omnichannel inquiry side panel item from @rocket.chat/string-helpers to @rocket.chat/tools.

Changes

escapeHTML import

Layer / File(s)	Summary
Update escapeHTML import `apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx`	The file imports `escapeHTML` from `@rocket.chat/tools` instead of `@rocket.chat/string-helpers`.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5b88c

This localized import fix restores the Omnichannel queue side panel build and preserves the intended escaped message preview behavior; no actionable merge-blocking risk remains after normal checks and review.

Suggested labels: type: bug

Suggested reviewers: julio-rocketchat, tassoevan

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the unresolved import regression and its impact on the Omnichannel queue side panel.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-08-18T13:15:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.23%. Comparing base (b2c16d5) to head (5b88cc2).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #41816   +/-   ##
========================================
  Coverage    69.23%   69.23%           
========================================
  Files         4234     4234           
  Lines       167280   167283    +3     
  Branches     29796    29779   -17     
========================================
+ Hits        115818   115821    +3     
+ Misses       46302    46300    -2     
- Partials      5160     5162    +2

Flag	Coverage Δ
e2e	`58.93% <ø> (+0.01%)`	⬆️
e2e-api	`45.90% <ø> (+0.03%)`	⬆️
unit	`71.17% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cubic-dev-ai

No issues found across 1 file

_{Re-trigger cubic}

dougfabris · 2026-08-18T13:29:20Z

Closing this one because it was fixed here: #41815

regression: unresolved @rocket.chat/string-helpers import breaks Om…

5b88cc2

…nichannel queue side panel Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>

abhinavkrin requested a review from a team as a code owner August 18, 2026 13:12

coderabbitai Bot added the type: bug label Aug 18, 2026

cubic-dev-ai Bot reviewed Aug 18, 2026

View reviewed changes

dougfabris closed this Aug 18, 2026

coderabbitai Bot mentioned this pull request Aug 19, 2026

Support root selectors in stylis logical-properties middleware #41867

Open

Navigation Menu

Uh oh!

regression: unresolved `@rocket.chat/string-helpers` import breaks Omnichannel queue side panel - #41816

regression: unresolved `@rocket.chat/string-helpers` import breaks Omnichannel queue side panel#41816
abhinavkrin wants to merge 1 commit into
developfrom
regression/string-helpers-import-omnichannel-side-panel

abhinavkrin commented Aug 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

dionisio-bot Bot commented Aug 18, 2026

Uh oh!

changeset-bot Bot commented Aug 18, 2026

Uh oh!

coderabbitai Bot commented Aug 18, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Aug 18, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

dougfabris commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

abhinavkrin commented Aug 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot Bot commented Aug 18, 2026

Uh oh!

changeset-bot Bot commented Aug 18, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

codecov Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

dougfabris commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

abhinavkrin commented Aug 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 18, 2026 •

edited

Loading

codecov Bot commented Aug 18, 2026 •

edited

Loading