Skip to content

fix: wrong imports in InquireSidePanelItem - #41815

Merged
julio-rocketchat merged 1 commit into
developfrom
fix-imports
Aug 18, 2026
Merged

fix: wrong imports in InquireSidePanelItem#41815
julio-rocketchat merged 1 commit into
developfrom
fix-imports

Conversation

@julio-rocketchat

@julio-rocketchat julio-rocketchat commented Aug 18, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

PR 41595 was merged but in the meantime there was a refactor in where escapeHTML came from (instead of helpers, we now have a tools package). This PR fixes it and serves as a part 2 to that initial PR that ended up breaking the code.

Issue(s)

#41595
https://rocketchat.atlassian.net/browse/VLN-531

Steps to test or reproduce

Further comments

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Improved HTML escaping behavior in the Omnichannel inquiry side panel.

@julio-rocketchat
julio-rocketchat requested a review from a team as a code owner August 18, 2026 12:25
@dionisio-bot

dionisio-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c716617

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62a3b153-4b48-473e-9693-45082ff0ae26

📥 Commits

Reviewing files that changed from the base of the PR and between b2c16d5 and c716617.

📒 Files selected for processing (1)
  • apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: CodeQL-Build
  • GitHub Check: Hacktron Security Check
  • GitHub Check: CodeQL-Build
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

  • apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx
apps/meteor/**

📄 CodeRabbit inference engine (CLAUDE.md)

The main Rocket.Chat Meteor application resides in apps/meteor/; place its application code there rather than in other monorepo areas.

Files:

  • apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx
🧠 Learnings (2)
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.

Applied to files:

  • apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.

Applied to files:

  • apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx
🔇 Additional comments (1)
apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx (1)

3-3: LGTM!


Walkthrough

The change updates the escapeHTML import in the omnichannel side panel item from @rocket.chat/string-helpers to @rocket.chat/tools.

Changes

escapeHTML import

Layer / File(s) Summary
Update escapeHTML import
apps/meteor/client/views/navigation/sidepanel/omnichannel/InquireSidePanelItem.tsx
The file imports escapeHTML from @rocket.chat/tools.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c7166

This is a localized import correction in the side-panel component; no actionable merge-blocking risk remains after normal checks and review.

Suggested labels: type: chore

Suggested reviewers: tassoevan, cardoso

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the corrected import in InquireSidePanelItem.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.24%. Comparing base (b2c16d5) to head (c716617).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #41815   +/-   ##
========================================
  Coverage    69.23%   69.24%           
========================================
  Files         4234     4234           
  Lines       167280   167283    +3     
  Branches     29796    29791    -5     
========================================
+ Hits        115818   115828   +10     
+ Misses       46302    46293    -9     
- Partials      5160     5162    +2     
Flag Coverage Δ
e2e 58.93% <ø> (+<0.01%) ⬆️
e2e-api 45.86% <ø> (-0.01%) ⬇️
unit 71.19% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-rocketchat
julio-rocketchat merged commit eb6eccc into develop Aug 18, 2026
53 checks passed
@julio-rocketchat
julio-rocketchat deleted the fix-imports branch August 18, 2026 12:45
@julio-rocketchat julio-rocketchat added this to the 8.8.0 milestone Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant