test: baseline tests for emojione behavior replaced by the native emoji migration - #41610
test: baseline tests for emojione behavior replaced by the native emoji migration#41610KevLehman wants to merge 1 commit into
Conversation
…ji migration Passing characterization tests documenting the 8.6 (emojione / emoji-toolkit) behavior that the native-emoji migration (#39411) regressed in 8.7: - emojione converts hair-style shortcodes (:bald: et al), :iphone:, shortcodes adjacent to timestamp-like text (12:30:fire:), and bare text-presentation emojis; hand-patched legacy shortcodes render in picker and messages - emoji-toolkit names transcript emojis with the app vocabulary (:thumbsup:, :smiley:) Counterpart PR against release-8.7.0 carries the same expectations as failing tests over the emoji-native implementation.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Counterpart red-test PR (same expectations failing on 8.7, post-migration): #41609 |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes (including videos or screenshots)
Passing characterization tests (11 green) documenting the 8.6 emojione/emoji-toolkit behavior that the native-emoji migration (#39411) regressed in 8.7:
apps/meteor/tests/unit/app/emoji/emojioneBaseline.spec.ts(mocha, 9 tests): emojione converts hair-style shortcodes (:bald:,:red_haired:,:curly_haired:,:white_haired:),:iphone:, a shortcode directly following an unknown:token:(12:30:fire:), bare text-presentation emojis (❤,☺); hand-patched legacy shortcodes (:digit_one:) render in picker and messages.ee/packages/pdf-worker/src/templates/ChatTranscript/markup/emoji.spec.ts(jest, 2 tests): emoji-toolkit names transcript emojis with the app vocabulary (:thumbsup:,:smiley:).Counterpart: the same expectations run as deliberately failing tests over the
emoji-nativeimplementation in the PR againstrelease-8.7.0(link in comments).Notes from writing the baseline:
emojione.shortnameToUnicode(':digit_one:')drops the U+20E3 combiner even on 8.6 — users saw the correct sprite via the render path, so the baseline assertsrender/renderPicker.emoji-toolkit.toShortdoes not handle bare❤on 8.6 either — transcript bare-emoji handling is not part of the baseline.Issue(s)
Baseline for regressions from #39411.
Steps to test or reproduce
Regressions covered (as passing 8.6 baseline)
These 8.7 regressions (IDs from the internal review triage; all runtime-verified there) have their pre-migration expected behavior pinned here:
:token:(12:30:fire:)emojioneBaseline.spec.ts› timestamp-adjacent (emojione converts it):bald::red_haired::curly_haired::white_haired:) render as literal textemojioneBaseline.spec.ts› hair-style ×4:iphone:renders as literal textemojioneBaseline.spec.ts›:iphone:❤☺lose emoji renderingemojioneBaseline.spec.ts› toShort bare forms:digit_one:) invisible in picker recentsemojioneBaseline.spec.ts› picker + message render:+1:) instead of app vocabularypdf-workeremoji.spec.ts›:thumbsup:/:smiley:Findings without a baseline here (and, after review, removed from the counterpart PR as well — they are pre-existing bugs or defects in new code, not migration regressions; to be fixed as separate bug fixes):
Further comments
Test-only change, no changeset. All 11 tests pass on this branch.