Skip to content

test: baseline tests for emojione behavior replaced by the native emoji migration - #41610

Closed
KevLehman wants to merge 1 commit into
release-8.6.1from
test/emoji-baseline-8.6
Closed

test: baseline tests for emojione behavior replaced by the native emoji migration#41610
KevLehman wants to merge 1 commit into
release-8.6.1from
test/emoji-baseline-8.6

Conversation

@KevLehman

@KevLehman KevLehman commented Jul 28, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Passing characterization tests (11 green) documenting the 8.6 emojione/emoji-toolkit behavior that the native-emoji migration (#39411) regressed in 8.7:

  • apps/meteor/tests/unit/app/emoji/emojioneBaseline.spec.ts (mocha, 9 tests): emojione converts hair-style shortcodes (:bald:, :red_haired:, :curly_haired:, :white_haired:), :iphone:, a shortcode directly following an unknown :token: (12:30:fire:), bare text-presentation emojis (, ); hand-patched legacy shortcodes (:digit_one:) render in picker and messages.
  • ee/packages/pdf-worker/src/templates/ChatTranscript/markup/emoji.spec.ts (jest, 2 tests): emoji-toolkit names transcript emojis with the app vocabulary (:thumbsup:, :smiley:).

Counterpart: the same expectations run as deliberately failing tests over the emoji-native implementation in the PR against release-8.7.0 (link in comments).

Notes from writing the baseline:

  • emojione.shortnameToUnicode(':digit_one:') drops the U+20E3 combiner even on 8.6 — users saw the correct sprite via the render path, so the baseline asserts render/renderPicker.
  • emoji-toolkit.toShort does not handle bare on 8.6 either — transcript bare-emoji handling is not part of the baseline.

Issue(s)

Baseline for regressions from #39411.

Steps to test or reproduce

cd apps/meteor && yarn mocha --config ./.mocharc.base.json --exit tests/unit/app/emoji/emojioneBaseline.spec.ts
cd ee/packages/pdf-worker && yarn jest src/templates/ChatTranscript/markup/emoji.spec.ts

Regressions covered (as passing 8.6 baseline)

These 8.7 regressions (IDs from the internal review triage; all runtime-verified there) have their pre-migration expected behavior pinned here:

ID 8.7 regression Baseline test proving 8.6 behavior
B1 Notification-text conversion skips a shortcode after an unknown :token: (12:30:fire:) emojioneBaseline.spec.ts › timestamp-adjacent (emojione converts it)
B2 Hair-style shortcodes (:bald: :red_haired: :curly_haired: :white_haired:) render as literal text emojioneBaseline.spec.ts › hair-style ×4
B3 :iphone: renders as literal text emojioneBaseline.spec.ts:iphone:
B4 Bare (no VS16) lose emoji rendering emojioneBaseline.spec.ts › toShort bare forms
C3 Legacy shortcodes (:digit_one:) invisible in picker recents emojioneBaseline.spec.ts › picker + message render
D2 PDF transcript emits emojibase-primary shortnames (:+1:) instead of app vocabulary pdf-worker emoji.spec.ts:thumbsup:/:smiley:

Findings without a baseline here (and, after review, removed from the counterpart PR as well — they are pre-existing bugs or defects in new code, not migration regressions; to be fixed as separate bug fixes):

  • C1/C2/C5 (custom-emoji delete nukes native entry; category truncation on one stale name; frequent-list empty slots) — the defective code and its trigger paths exist identically on 8.6.
  • C4 (mixed-tone variants missing from picker search) — dead branch in new code; emojione 4.5 predates the Unicode 12 mixed-tone emojis involved.
  • Federation reactions — already fixed in regression: federated reactions dropped or sent as raw shortcode text #41606.

Further comments

Test-only change, no changeset. All 11 tests pass on this branch.

Review in cubic

…ji migration

Passing characterization tests documenting the 8.6 (emojione /
emoji-toolkit) behavior that the native-emoji migration (#39411)
regressed in 8.7:

- emojione converts hair-style shortcodes (:bald: et al), :iphone:,
  shortcodes adjacent to timestamp-like text (12:30:fire:), and bare
  text-presentation emojis; hand-patched legacy shortcodes render in
  picker and messages
- emoji-toolkit names transcript emojis with the app vocabulary
  (:thumbsup:, :smiley:)

Counterpart PR against release-8.7.0 carries the same expectations
as failing tests over the emoji-native implementation.
@dionisio-bot

dionisio-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ef70f14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman

Copy link
Copy Markdown
Member Author

Counterpart red-test PR (same expectations failing on 8.7, post-migration): #41609

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 330266ba-737a-438e-a7cd-bf87ce400287

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KevLehman KevLehman closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant