regression: federated reactions dropped or sent as raw shortcode text - #41606
regression: federated reactions dropped or sent as raw shortcode text#41606KevLehman wants to merge 1 commit into
Conversation
The federation emoji converter built its maps from the emojibase shortcode preset while the app emoji list is joypixels-first, so outbound reactions with joypixels-only shortnames reached Matrix as literal text and inbound emojibase-primary shortnames were rejected by setReaction. Unqualified reaction keys (no VS16) also missed the unicode map. Align the converter with the app: joypixels-first shortcodes, bare-form unicode aliases, legacy emojione backfill.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.7.0 #41606 +/- ##
==============================================
Coverage 68.40% 68.40%
==============================================
Files 4139 4140 +1
Lines 158309 158335 +26
Branches 28305 28324 +19
==============================================
+ Hits 108290 108314 +24
- Misses 44882 44884 +2
Partials 5137 5137
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
The federation emoji converter (
ee/packages/federation-matrix/src/utils/emojiConverter.ts) built its shortcode maps from the emojibase preset, while the app emoji list is joypixels-first since the native emoji migration (#39411, aligned by #41587). The converter was never updated, breaking federated reactions in both directions::slight_smile:,:upside_down:, tone variants like:hand_splayed_tone3:) don't resolve, so Matrix/Element users see the literal shortcode text as the reaction key instead of the emoji.unicodeToShortnameemits emojibase-primary names (:grinning_face_with_big_eyes:) that are not in the app'semoji.list, sosetReactionthrowsInvalid emoji providedand the reaction is silently dropped. Affects ~620 emojis including 😃 😄 😅 😘 🤗 😎.:thumbsup:local vs:+1:federated), and contested shortcodes diverged in meaning (:cat:→ 🐈 outbound while RC renders 🐱).Fix aligns the converter with the app's emoji data:
legacyEmojioneMap)Issue(s)
Regression from #39411
Steps to test or reproduce
:slight_smile:) → Element previously showed the literal text:slight_smile:; now shows 🙂.Invalid emoji providedin logs; now the reaction appears and aggregates with local:thumbsup:reactions.Further comments
Unit spec added covering both directions, tone variants, legacy shortcodes and unqualified keys. No changeset (regression fix targeting release-8.7.0).