chore: Allow clients to register a session after accepting a call - #38736
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughThis change modifies session registration and call handling logic to support mobile voice clients accepting calls before initiating sessions. It removes a contract-id validation check that previously terminated same-session calls and introduces optional mobile device ID support for session identification. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38736 +/- ##
===========================================
- Coverage 70.51% 70.49% -0.03%
===========================================
Files 3176 3176
Lines 111139 111139
Branches 20050 20049 -1
===========================================
- Hits 78367 78342 -25
- Misses 30721 30756 +35
+ Partials 2051 2041 -10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Currently if we register a session with an ID that is already linked to a call, the server will end that call assuming that it was happening on a session that was refreshed. With #38646 a session may be linked to a call before actually being registered, so we need to change the registration process to not drop those calls anymore.
The PR also adds the option to register a session with a specific ID instead of generating a random one.
Issue(s)
VMUX-39
Steps to test or reproduce
Further comments
Summary by CodeRabbit
Bug Fixes
New Features