Skip to content

chore: Allow clients to register a session after accepting a call #38736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierre-lehnen-rc merged 1 commit into from
Mar 12, 2026
Merged

chore: Allow clients to register a session after accepting a call #38736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ee/packages/media-calls/src/internal/SignalProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,8 @@ export class GlobalSignalProcessor {

// If this user's side of the call has already been signed
if (actor.contractId) {
// If it's signed to the same session that is now registering
// Or it was signed by a session that the current session is replacing (as in a browser refresh)
if (actor.contractId === signal.contractId || actor.contractId === signal.oldContractId) {
// If it was signed by a session that the current session is replacing (as in a browser refresh)
if (actor.contractId === signal.oldContractId) {
logger.info({ msg: 'Server detected a client refresh for a session with an active call.', callId: call._id });
await mediaCallDirector.hangupDetachedCall(call, { endedBy: { ...actor, contractId: signal.contractId }, reason: 'unknown' });
return;
Expand Down
3 changes: 2 additions & 1 deletion packages/media-signaling/src/lib/Session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export type MediaSignalingEvents = {

export type MediaSignalingSessionConfig = {
userId: string;
mobileDeviceId?: string;
oldSessionId?: string;
logger?: IMediaSignalLogger;
processorFactories: IServiceProcessorFactoryList;
Expand Down Expand Up @@ -74,7 +75,7 @@ export class MediaSignalingSession extends Emitter<MediaSignalingEvents> {
constructor(private config: MediaSignalingSessionConfig) {
super();
this._userId = config.userId;
this._sessionId = config.randomStringFactory();
this._sessionId = config.mobileDeviceId || config.randomStringFactory();
this.recurringStateReportHandler = null;
this.knownCalls = new Map<string, ClientMediaCall>();
this.ignoredCalls = new Set<string>();
Expand Down
Loading