refactor(admin): remove unnecessary aria-label in MultiSelectSettingInput

[Ironankit525]

Title:

refactor(admin): remove unnecessary aria-label in MultiSelectSettingInput

Description:

Proposed changes
Removes the aria-label workaround in MultiSelectSettingInput.tsx. The component now relies on the standard FieldLabel association via htmlFor, aligning with accessibility best practices and removing a legacy FIXME comment.

Changes made:

• Removed hardcoded aria-label prop from MultiSelect component
• Component now uses proper label association through FieldLabel and htmlFor
• Cleaned up FIXME comment

This brings the MultiSelect input in line with how other setting inputs handle label associations.

Issue(s)

Resolves FIXME in apps/meteor/client/views/admin/settings/Setting/inputs/MultiSelectSettingInput.tsx

Steps to test or reproduce

• Navigate to Administration → Settings

• Find any setting that uses a MultiSelect input (e.g., Accounts → Preferences)

• Test accessibility:

  • Use a screen reader to verify the label is properly announced
  • Inspect the DOM to confirm the label-input association is correct
  • Click the label and verify it focuses the input

• Verify the input functions normally (selecting/deselecting values works as expected)

Further comments

This creates a cleaner, more semantic DOM structure and follows the accessibility pattern used consistently throughout the settings UI. The htmlFor association is the standard way to connect labels with form inputs, making the aria-label redundant.

Key improvements:

• Changed scope from client to admin (more specific)
• Added accessibility testing steps (important for this type of change)
• Explained why the change matters for accessibility
• Clearer rationale for the refactor

Summary by CodeRabbit

Release Notes

• Refactor
  • Improved code quality by removing an unnecessary accessibility attribute from the multi-select settings input component.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 50534a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/http-router	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/abac	Patch
@rocket.chat/federation-matrix	Patch
@rocket.chat/license	Patch
@rocket.chat/media-calls	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/omni-core-ee	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/instance-status	Patch
@rocket.chat/omni-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Walkthrough

This PR removes an unnecessary aria-label prop assignment from a MultiSelect component in the MultiSelectSettingInput file and adds a corresponding patch release note to the changeset documentation.

Changes

Cohort / File(s)	Summary
Changeset Documentation .changeset/clever-cats-sing.md	Added patch release note for @rocket.chat/meteor documenting the aria-label removal refactor.
Accessibility Prop Removal apps/meteor/client/views/admin/settings/Setting/inputs/MultiSelectSettingInput.tsx	Removed unnecessary aria-label={_id} prop assignment (with FIXME comment) from MultiSelect component.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• regression(ABAC): Adjust forms spacing and accessibility. #37872: Both PRs modify ARIA attributes passed to MultiSelect components, removing or adjusting aria-label/ARIA props.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• dougfabris
• tassoevan

Poem

🐰 Through the code I hop with care,
Found an aria-label floating there,
One swift snip, now the field's so clean,
Best refactor the code has seen! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically summarizes the main change: removing an unnecessary aria-label from MultiSelectSettingInput.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 2 files