Skip to content

refactor(admin): remove unnecessary aria-label in MultiSelectSettingInput #38303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ironankit525 wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −1
Open

refactor(admin): remove unnecessary aria-label in MultiSelectSettingInput #38303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cea147f
refactor(client): remove unnecessary aria-label in MultiSelectSetting…
Ironankit525 Jan 23, 2026
50534a1
chore: add changeset
Ironankit525 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-cats-sing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

refactor(client): remove unnecessary aria-label in MultiSelectSettingInput
1 change: 0 additions & 1 deletion apps/meteor/client/views/admin/settings/Setting/inputs/MultiSelectSettingInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ function MultiSelectSettingInput({
// autoComplete={autocomplete === false ? 'off' : undefined}
onChange={handleChange}
options={values.map(({ key, i18nLabel }) => [key, t(i18nLabel)])}
aria-label={_id} // FIXME: Multiselect (fuselage) should be associating the FieldLabel automatically. This is a workaround for accessibility and test locators.
/>
</FieldRow>
{hint && <FieldHint>{hint}</FieldHint>}
Expand Down