Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jan 19, 2026

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1715

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Improved internal logging format across multiple server modules to enhance system monitoring and diagnostics. No functional changes to user-facing features or behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 19, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2026

⚠️ No Changeset found

Latest commit: 87d85fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

Walkthrough

Systematically converts string-based SystemLogger calls to structured object logs containing msg and relevant metadata fields across 15 server files. No control flow or error handling logic changes; only logging format and payload structure are modified.

Changes

Cohort / File(s) Summary
Cloud & Workspace Management
apps/meteor/app/cloud/server/functions/getWorkspaceAccessToken.ts, apps/meteor/app/cloud/server/functions/supportedVersionsToken/supportedVersionsToken.ts
Converts debug and error logs to structured objects with msg field and context data (e.g., key, retry).
Storage Configuration
apps/meteor/app/custom-sounds/server/startup/custom-sounds.js, apps/meteor/app/emoji-custom/server/startup/emoji-custom.js, apps/meteor/app/file-upload/server/config/_configUploadStorage.ts
Replaces string interpolation with structured objects logging storage type selection, now including msg and storeType fields.
File Upload & Avatar Management
apps/meteor/app/file-upload/server/lib/FileUpload.ts, apps/meteor/app/lib/server/functions/setUserAvatar.ts
Converts error and info logs to structured format with msg and metadata (e.g., handlerName, url, status, contentType).
Communication & Messaging
apps/meteor/app/livechat/server/sendMessageBySMS.ts, apps/meteor/app/mail-messages/server/functions/sendMail.ts, apps/meteor/app/message-mark-as-unread/server/unreadMessages.ts
Replaces string logs with structured objects containing msg and context fields (phoneNumber, service, email, timestamp).
Push Notifications
apps/meteor/app/push/server/apn.ts, apps/meteor/app/push/server/push.ts
Converts debug and warning logs to structured objects with msg, status, token, userId, title, and error details.
Authentication (SAML)
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts, apps/meteor/app/meteor-accounts-saml/server/lib/settings.ts, apps/meteor/app/meteor-accounts-saml/server/listener.ts
Replaces string warnings and error logs with structured objects containing msg, roles, and serviceName fields.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • sampaiodiego
  • pierre-lehnen-rc
  • aleksandernsilva

Poem

🐰 Logs now dress in structured clothes,
With msg fields and metadata rows,
No longer strings that twist and turn,
But objects clean—a rabbit's concern! 📝

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive The linked issue CORE-1715 has no visible description or requirements, making it impossible to validate whether the code changes meet its specific objectives. Provide or verify the detailed requirements for issue CORE-1715 to confirm all coding objectives are met by this pull request.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: Adapt logs to new format' clearly and concisely summarizes the main change—converting string-based logs to structured object-based logging across multiple files.
Out of Scope Changes check ✅ Passed All changes are consistently focused on adapting logging from string interpolation to structured object format across server-side logging calls, with no unrelated modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/logs-format-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.70%. Comparing base (90243eb) to head (87d85fd).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #38259      +/-   ##
===========================================
- Coverage    70.70%   70.70%   -0.01%     
===========================================
  Files         3139     3139              
  Lines       108744   108744              
  Branches     19560    19562       +2     
===========================================
- Hits         76887    76884       -3     
+ Misses       29856    29854       -2     
- Partials      2001     2006       +5     
Flag Coverage Δ
e2e 60.27% <ø> (-0.05%) ⬇️
e2e-api 47.96% <ø> (ø)
unit 71.83% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman added this to the 8.1.0 milestone Jan 19, 2026
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jan 19, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 19, 2026
@KevLehman KevLehman marked this pull request as ready for review January 19, 2026 15:24
@KevLehman KevLehman requested review from a team as code owners January 19, 2026 15:24
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

📦 Docker Image Size Report

➡️ Changes

Service Current Baseline Change Percent
sum of all images 0B 0B 0B
account-service 0B 0B 0B
authorization-service 0B 0B 0B
ddp-streamer-service 0B 0B 0B
omnichannel-transcript-service 0B 0B 0B
presence-service 0B 0B 0B
queue-worker-service 0B 0B 0B
rocketchat 0B 0B 0B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "01/19 19:56 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]
Loading

Statistics (last 30 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.4GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 0B
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-38259
  • Baseline: develop
  • Timestamp: 2026-01-19 19:56:23 UTC
  • Historical data points: 30

Updated: Mon, 19 Jan 2026 19:56:23 GMT

@kodiakhq kodiakhq bot merged commit 0b438a5 into develop Jan 19, 2026
44 checks passed
@kodiakhq kodiakhq bot deleted the chore/logs-format-5 branch January 19, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants