chore: Adapt logs to object format #38270

KevLehman · 2026-01-20T02:37:16Z

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1715

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Chores
- Standardized logging platform-wide: replaced string-template logs with structured object logs across search, authentication/LDAP, LiveChat Enterprise, email inbox, CAS, apps engine, core services, and visitor handling. No functional or API behavior changed—only log format and metadata were updated to improve consistency and observability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

changeset-bot · 2026-01-20T02:37:19Z

⚠️ No Changeset found

Latest commit: 1c7c16c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dionisio-bot · 2026-01-20T02:37:20Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

coderabbitai · 2026-01-20T02:37:23Z

Walkthrough

Systematic refactor replacing string-interpolated logger calls with structured object payloads across server code (search, livechat, LDAP, email inbox, CAS, core packages). No control-flow, API signatures, or functional behavior were modified; only log message formatting and fields changed.

Changes

Cohort / File(s)	Summary
Search module `apps/meteor/app/search/server/events/EventService.ts`, `apps/meteor/app/search/server/model/SearchProvider.ts`, `apps/meteor/app/search/server/service/SearchProviderService.ts`, `apps/meteor/app/search/server/service/SearchResultValidationService.ts`	Replaced string-template logs with structured objects (e.g., msg, eventName, providerKey, userId, roomId). Access checks and logic unchanged.
Livechat Enterprise (API, hooks, services) `apps/meteor/ee/app/livechat-enterprise/server/api/contacts.ts`, `apps/meteor/ee/app/livechat-enterprise/server/api/lib/departments.ts`, `apps/meteor/ee/app/livechat-enterprise/server/hooks/afterForwardChatToDepartment.ts`, `apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts`, `apps/meteor/ee/app/livechat-enterprise/server/lib/requestPdfTranscript.ts`, `apps/meteor/ee/app/livechat-enterprise/server/startup.ts`	Converted logs to structured objects (fields like msg, visitorId, userId, departmentId, roomId, count, value). No behavioral changes.
LDAP integration `apps/meteor/ee/server/lib/ldap/Manager.ts`, `apps/meteor/server/lib/ldap/Connection.ts`, `apps/meteor/server/lib/ldap/Manager.ts`	Swapped string logs for structured objects (msg, username, dn, groupName, foundEntries, count, err). Control flow unchanged.
Email Inbox `apps/meteor/server/features/EmailInbox/EmailInbox.ts`, `apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts`	Replaced interpolated email logs with structured objects (msg, email, inbox, department, address, err).
CAS authentication `apps/meteor/server/lib/cas/createNewUser.ts`, `apps/meteor/server/lib/cas/loginHandler.ts`, `apps/meteor/server/lib/cas/middleware.ts`	Converted debug/info logs to structured objects carrying context (msg, username, userId, baseUrl, ticketId, internalName, value).
Core framework & services `packages/apps-engine/src/definition/App.ts`, `packages/core-services/src/LocalBroker.ts`, `packages/omni-core/src/visitor/create.ts`	Updated status/startup/visitor creation logs to structured-object payloads (msg plus fields like status, serviceName, pendingDependencies, token, department).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

chore: Adapt logs to object format - 3 #38111 — Same code-level change: convert string-template logger calls to structured object logs across server files.
chore: Adapt logs to new object format #38207 — Similar logging-format refactor affecting overlapping server modules (LDAP, livechat, etc.).
chore: Adapt logs to object format #38204 — Overlaps on LDAP and livechat logging-site edits; same migration pattern.

Suggested reviewers

sampaiodiego
d-gubert
pierre-lehnen-rc

Poem

🐰 I hopped through logs with tiny feet,
Swapped strings for keys to make them neat,
Now messages whisper structured cheer,
Fields aligned and crystal clear,
A quiet hop — the logs repeat.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: Adapt logs to object format' clearly and concisely summarizes the main change across all modified files.
Linked Issues check	✅ Passed	The PR adapts server logs to structured object format (CORE-1715), converting string templates to objects with msg and context fields across 20+ files without altering control flow.
Out of Scope Changes check	✅ Passed	All changes are in-scope: logging format conversions from string templates to structured objects. No unrelated logic, dependencies, or functionality modifications are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/logs-again

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-20T14:03:07Z

Codecov Report

❌ Patch coverage is 24.13793% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.77%. Comparing base (c9103e8) to head (1c7c16c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #38270      +/-   ##
===========================================
+ Coverage    70.75%   70.77%   +0.02%     
===========================================
  Files         3142     3142              
  Lines       108927   108927              
  Branches     19603    19693      +90     
===========================================
+ Hits         77066    77095      +29     
+ Misses       29864    29836      -28     
+ Partials      1997     1996       -1

Flag	Coverage Δ
e2e	`60.32% <ø> (-0.01%)`	⬇️
e2e-api	`48.11% <16.66%> (-1.05%)`	⬇️
unit	`71.91% <36.36%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-01-20T14:07:01Z

📦 Docker Image Size Report

➡️ Changes

Service	Current	Baseline	Change
sum of all images	0B	0B	0B
account-service	0B	0B	0B
authorization-service	0B	0B	0B
ddp-streamer-service	0B	0B	0B
omnichannel-transcript-service	0B	0B	0B
presence-service	0B	0B	0B
queue-worker-service	0B	0B	0B
rocketchat	0B	0B	0B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "01/20 20:47 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]

Statistics (last 30 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.4GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 0B

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-38270
Baseline: develop
Timestamp: 2026-01-20 20:47:08 UTC
Historical data points: 30

Updated: Tue, 20 Jan 2026 20:47:09 GMT

cubic-dev-ai

No issues found across 21 files

apps/meteor/ee/server/lib/ldap/Manager.ts

KevLehman added 2 commits January 19, 2026 20:18

8

9014e9c

15

ded9584

KevLehman added 2 commits January 19, 2026 20:38

unneded objc

caf3509

cr

144c5c7

KevLehman marked this pull request as ready for review January 20, 2026 14:09

KevLehman requested review from a team as code owners January 20, 2026 14:09

cubic-dev-ai bot reviewed Jan 20, 2026

View reviewed changes

sampaiodiego requested changes Jan 20, 2026

View reviewed changes

apps/meteor/ee/server/lib/ldap/Manager.ts Outdated Show resolved Hide resolved

fix

9c2e628

KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jan 20, 2026

sampaiodiego approved these changes Jan 20, 2026

View reviewed changes

sampaiodiego added this to the 8.1.0 milestone Jan 20, 2026

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2026

Merge branch 'develop' into chore/logs-again

1c7c16c

kodiakhq bot merged commit 220f619 into develop Jan 20, 2026
45 checks passed

kodiakhq bot deleted the chore/logs-again branch January 20, 2026 21:08

This was referenced Jan 21, 2026

chore: Adapt logs to object format (almost) #38280

Merged

chore: Adapt logs to object format (final!) #38289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Adapt logs to object format #38270

chore: Adapt logs to object format #38270

Uh oh!

KevLehman commented Jan 20, 2026 •

edited by atlassian bot

Loading

Uh oh!

changeset-bot bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

dionisio-bot bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: Adapt logs to object format #38270

chore: Adapt logs to object format #38270

Uh oh!

Conversation

KevLehman commented Jan 20, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

dionisio-bot bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

➡️ Changes

📊 Historical Trend

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KevLehman commented Jan 20, 2026 •

edited by atlassian bot

Loading

changeset-bot bot commented Jan 20, 2026 •

edited

Loading

dionisio-bot bot commented Jan 20, 2026 •

edited

Loading

coderabbitai bot commented Jan 20, 2026 •

edited

Loading

codecov bot commented Jan 20, 2026 •

edited

Loading

github-actions bot commented Jan 20, 2026 •

edited

Loading