-
Notifications
You must be signed in to change notification settings - Fork 13k
fix(federation): add missing userIdSchema validation for non-native federated users #37937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.0.0 #37937 +/- ##
=================================================
+ Coverage 71.73% 71.77% +0.03%
=================================================
Files 1453 1453
Lines 76689 76689
Branches 11133 11138 +5
=================================================
+ Hits 55013 55043 +30
+ Misses 21249 21218 -31
- Partials 427 428 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
createDirectMessageRoommethoduserIdSchema.parse()for consistency withinviteUsersToRoom(line 553) and to ensure proper type safetyChanges
ee/packages/federation-matrix/src/FederationMatrix.ts: AddeduserIdSchema.parse()validation for the constructed user ID when inviting non-native federated users to group DM roomsTest plan
🤖 Generated with Claude Code