fix(federation): add missing await before retry() in room.spec.ts #37936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a missing
awaitbefore theretry()call in the federation Matrix end-to-end test.Problem
The
retryfunction is async and returns a Promise. Withoutawait, the test at line 1616 would complete immediately without waiting for the assertions to run, potentially causing false positive test results where tests pass even when the actual assertions would fail.Solution
Added
awaitbefore theretry()call to ensure the test properly waits for all retry attempts and assertions to complete.Changes
ee/packages/federation-matrix/tests/end-to-end/room.spec.ts: Added missingawaitbeforeretry()call in the "It should show all the three users in the members list" test