Skip to content

Conversation

@cubic-dev-ai
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot commented Dec 22, 2025

Summary

Fixes a missing await before the retry() call in the federation Matrix end-to-end test.

Problem

The retry function is async and returns a Promise. Without await, the test at line 1616 would complete immediately without waiting for the assertions to run, potentially causing false positive test results where tests pass even when the actual assertions would fail.

Solution

Added await before the retry() call to ensure the test properly waits for all retry attempts and assertions to complete.

Changes

  • ee/packages/federation-matrix/tests/end-to-end/room.spec.ts: Added missing await before retry() call in the "It should show all the three users in the members list" test

@cubic-dev-ai cubic-dev-ai bot requested a review from sampaiodiego December 22, 2025 23:27
@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: 022dfc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


cubic-dev-ai[bot] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ggazzo ggazzo merged commit 0702489 into regression-federation-mixed-dm-invite-not-working Dec 22, 2025
5 of 8 checks passed
@ggazzo ggazzo deleted the fix/missing-await-retry-federation-test branch December 22, 2025 23:27
Copy link
Contributor Author

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants