Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Dec 22, 2025

Proposed changes (including videos or screenshots)

This pull request makes several updates to the build and lint configuration for the packages/sha256 package. The main changes remove Babel-related configuration and dependencies, simplify ESLint settings, and adjust TypeScript build options for better output management.

Build system cleanup:

  • Removed Babel configuration file babel.config.js and related dependencies from package.json, indicating the package no longer uses Babel for transpilation. [1] [2]

Linting configuration updates:

  • Simplified .eslintrc.json by removing the jest plugin and environment settings, streamlining the linting process.
  • Removed TypeScript ESLint plugin and parser dependencies from package.json, further simplifying lint setup.

TypeScript configuration improvements:

  • Moved the outDir setting from tsconfig.json to tsconfig.build.json for clearer separation between source and build configuration. [1] [2]
  • Updated the exclude pattern in tsconfig.build.json to only exclude TypeScript spec files, ensuring proper build output.

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Removed development dependencies including Babel and TypeScript ESLint tooling from the sha256 package.
    • Simplified build configuration by removing Jest and Babel setup files.
    • Updated TypeScript build settings to output to the dist directory.

✏️ Tip: You can customize this high-level summary in your review settings.

@tassoevan tassoevan added this to the 8.1.0 milestone Dec 22, 2025
@tassoevan tassoevan requested a review from a team December 22, 2025 16:32
@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: 407c0c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Walkthrough

This PR streamlines the build configuration for the sha256 package by removing Jest-related ESLint rules, deleting the Babel configuration file, removing unused Babel and TypeScript ESLint dev dependencies, and reorganizing TypeScript compiler options between base and build-specific configs.

Changes

Cohort / File(s) Summary
ESLint & Babel configuration
packages/sha256/.eslintrc.json, packages/sha256/babel.config.js
Removed Jest plugin and globals configuration from ESLint. Deleted entire Babel configuration file (preset-env).
Dependencies
packages/sha256/package.json
Removed four dev dependencies: @babel/core, @babel/preset-env, @typescript-eslint/eslint-plugin, and @typescript-eslint/parser.
TypeScript build configuration
packages/sha256/tsconfig.json, packages/sha256/tsconfig.build.json
Moved "outDir": "dist" from base config to build-specific config. Removed "strictNullChecks": true from base config. Removed "**/*.spec.js" from exclude patterns in build config.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Configuration and dependency removals with minimal impact on runtime behavior
  • Changes follow a consistent pattern across related config files
  • No logic changes or feature additions requiring complex reasoning

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • ggazzo

Poem

🐰 Babel and Jest, we bid you adieu,
Config cleaned up, dependencies too,
TypeScript now builds with outDir so fine,
Dependencies slim, the package will shine!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary purpose of the changeset: reviewing and updating build configuration files for the sha256 package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/sha256-build-configuration

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a587ab3 and 407c0c6.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (5)
  • packages/sha256/.eslintrc.json
  • packages/sha256/babel.config.js
  • packages/sha256/package.json
  • packages/sha256/tsconfig.build.json
  • packages/sha256/tsconfig.json
💤 Files with no reviewable changes (4)
  • packages/sha256/tsconfig.json
  • packages/sha256/babel.config.js
  • packages/sha256/.eslintrc.json
  • packages/sha256/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to **/*.spec.ts : Use `.spec.ts` extension for test files (e.g., `login.spec.ts`)

Applied to files:

  • packages/sha256/tsconfig.build.json
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to **/*.{ts,tsx,js} : Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests

Applied to files:

  • packages/sha256/tsconfig.build.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (2)
packages/sha256/tsconfig.build.json (2)

4-4: LGTM! Good practice to separate build output configuration.

Moving outDir to the build-specific configuration separates build artifacts from the base TypeScript configuration used by IDEs and editors.


11-11: The exclude pattern correctly targets the package's actual test files. Only TypeScript spec files (.spec.ts) exist in this package, and the pattern appropriately excludes them from the build output.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.78%. Comparing base (a587ab3) to head (407c0c6).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37923      +/-   ##
===========================================
+ Coverage    71.70%   71.78%   +0.08%     
===========================================
  Files         1453     1453              
  Lines        76689    76689              
  Branches     11138    11156      +18     
===========================================
+ Hits         54988    55052      +64     
+ Misses       21274    21209      -65     
- Partials       427      428       +1     
Flag Coverage Δ
unit 71.78% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.1GiB 1.1GiB +11MiB
rocketchat 355MiB 345MiB +11MiB
omnichannel-transcript-service 132MiB 132MiB -222B
queue-worker-service 132MiB 132MiB -758B
ddp-streamer-service 126MiB 126MiB +2B
account-service 113MiB 113MiB +543B
authorization-service 111MiB 111MiB +37B
presence-service 111MiB 111MiB +568B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 16:58 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
Loading

Statistics (last 26 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.1GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37923
  • Baseline: develop
  • Timestamp: 2025-12-22 16:58:59 UTC
  • Historical data points: 26

Updated: Mon, 22 Dec 2025 16:58:59 GMT

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Dec 22, 2025
@ggazzo ggazzo merged commit ff615ea into develop Dec 22, 2025
44 of 45 checks passed
@ggazzo ggazzo deleted the chore/sha256-build-configuration branch December 22, 2025 18:17
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants