-
Notifications
You must be signed in to change notification settings - Fork 13k
chore(base64): Review build configuration #37899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
WalkthroughThis PR consolidates the build configuration for the base64 package by removing per-package Babel and Jest configurations, eliminating associated devDependencies, and reorganizing TypeScript compiler settings between root and build-specific configs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes These changes involve straightforward configuration removals and adjustments with no logic alterations or interdependencies. All modifications are configuration-level only. Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (4)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-11-24T17:08:17.065ZApplied to files:
📚 Learning: 2025-11-24T17:08:17.065ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes (including videos or screenshots)
This pull request cleans up and simplifies the configuration for the
@rocket.chat/base64package, focusing on removing unnecessary dependencies and configuration files, and making TypeScript build settings more precise. The main changes are grouped into configuration cleanup and TypeScript build improvements.Configuration cleanup:
babel.config.js,@babel/core,@babel/preset-env). [1] [2].eslintrc.json.devDependencies.TypeScript build improvements:
outDirsetting fromtsconfig.jsontotsconfig.build.json, clarifying build output configuration. [1] [2]excludefield intsconfig.build.jsonto only exclude TypeScript spec files, ensuring JavaScript spec files are included if present.Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.