Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Dec 19, 2025

Proposed changes (including videos or screenshots)

This pull request cleans up and simplifies the configuration for the @rocket.chat/base64 package, focusing on removing unnecessary dependencies and configuration files, and making TypeScript build settings more precise. The main changes are grouped into configuration cleanup and TypeScript build improvements.

Configuration cleanup:

  • Removed Babel configuration and related dependencies, as they are no longer needed for the build process (babel.config.js, @babel/core, @babel/preset-env). [1] [2]
  • Simplified ESLint configuration by removing Jest-specific settings from .eslintrc.json.
  • Removed unused TypeScript ESLint plugins from devDependencies.

TypeScript build improvements:

  • Moved the outDir setting from tsconfig.json to tsconfig.build.json, clarifying build output configuration. [1] [2]
  • Updated the exclude field in tsconfig.build.json to only exclude TypeScript spec files, ensuring JavaScript spec files are included if present.

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Updated TypeScript and ESLint build configuration for the base64 package and removed unused build-related dependencies.

✏️ Tip: You can customize this high-level summary in your review settings.

@tassoevan tassoevan added this to the 7.14.0 milestone Dec 19, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 19, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

⚠️ No Changeset found

Latest commit: 11c758c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan requested a review from a team December 19, 2025 19:08
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 19, 2025

Walkthrough

This PR consolidates the build configuration for the base64 package by removing per-package Babel and Jest configurations, eliminating associated devDependencies, and reorganizing TypeScript compiler settings between root and build-specific configs.

Changes

Cohort / File(s) Summary
ESLint Jest config removal
packages/base64/.eslintrc.json
Removed jest plugin entry and env.jest/globals setting; retained shared config extension and ignore patterns.
Babel configuration cleanup
packages/base64/babel.config.js
Deleted entire module export containing Babel preset configuration.
Development dependencies
packages/base64/package.json
Removed @babel/core, @babel/preset-env, @typescript-eslint/eslint-plugin, and @typescript-eslint/parser from devDependencies.
TypeScript build config
packages/base64/tsconfig.build.json
Added outDir: "dist" compiler option; narrowed exclude pattern from "**/*.spec.js" to "**/*.spec.ts" only.
TypeScript root config
packages/base64/tsconfig.json
Removed outDir: "dist" and strictNullChecks: true compiler options.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

These changes involve straightforward configuration removals and adjustments with no logic alterations or interdependencies. All modifications are configuration-level only.

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • ggazzo

Poem

🐰 With Babel gone and Jest config cleared,
The config bleeds to one that's revered,
TypeScript paths now neatly aligned,
A cleaner base64, beautifully refined!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(base64): Review build configuration' accurately describes the main changes in the PR, which involve simplifying and cleaning up build configuration files for the base64 package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/base64-build-configuration

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cc3a99f and 11c758c.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (5)
  • packages/base64/.eslintrc.json (0 hunks)
  • packages/base64/babel.config.js (0 hunks)
  • packages/base64/package.json (0 hunks)
  • packages/base64/tsconfig.build.json (1 hunks)
  • packages/base64/tsconfig.json (0 hunks)
💤 Files with no reviewable changes (4)
  • packages/base64/package.json
  • packages/base64/.eslintrc.json
  • packages/base64/tsconfig.json
  • packages/base64/babel.config.js
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to **/*.spec.ts : Use `.spec.ts` extension for test files (e.g., `login.spec.ts`)

Applied to files:

  • packages/base64/tsconfig.build.json
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to **/*.{ts,tsx,js} : Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests

Applied to files:

  • packages/base64/tsconfig.build.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (2)
packages/base64/tsconfig.build.json (2)

4-4: LGTM: Build output directory properly configured.

Moving outDir to the build-specific configuration improves separation of concerns and clarifies that this setting applies only during builds.


11-11: No action needed. This package contains only TypeScript spec files (.spec.ts), and no JavaScript spec files (.spec.js) exist. The exclusion pattern change has no impact on the build output.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 358MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB +114B
queue-worker-service 132MiB 132MiB -199B
ddp-streamer-service 126MiB 126MiB +150B
account-service 113MiB 113MiB -17B
authorization-service 111MiB 111MiB +1.1KiB
stream-hub-service 111MiB 111MiB +659B
presence-service 111MiB 111MiB -141B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 19:04", "12/19 19:58 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 25 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37899
  • Baseline: develop
  • Timestamp: 2025-12-19 19:58:58 UTC
  • Historical data points: 25

Updated: Fri, 19 Dec 2025 19:58:58 GMT

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Dec 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 19, 2025
@ggazzo ggazzo merged commit 82fbda2 into develop Dec 19, 2025
46 of 48 checks passed
@ggazzo ggazzo deleted the chore/base64-build-configuration branch December 19, 2025 20:13
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
@dougfabris dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants