Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Sep 4, 2025

Proposed changes (including videos or screenshots)

In order to be able to create snapshot tests for PermissionsTable its necessary to decouple it from the permissions page, allowing permissions mocking.

Issue(s)

Steps to test or reproduce

Further comments

CORE-1323

@dougfabris dougfabris added this to the 7.11.0 milestone Sep 4, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 4, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

⚠️ No Changeset found

Latest commit: cf80e91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris force-pushed the refactor/permissionsTable branch from 5b755cf to e9c3461 Compare September 4, 2025 18:49
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 94.58128% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.18%. Comparing base (02252b1) to head (cf80e91).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36872      +/-   ##
===========================================
+ Coverage    66.07%   66.18%   +0.11%     
===========================================
  Files         3337     3339       +2     
  Lines       113017   113419     +402     
  Branches     21128    21149      +21     
===========================================
+ Hits         74678    75072     +394     
- Misses       35654    35658       +4     
- Partials      2685     2689       +4     
Flag Coverage Δ
e2e 57.70% <62.50%> (+0.02%) ⬆️
unit 70.90% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review September 4, 2025 20:47
@dougfabris dougfabris requested a review from a team as a code owner September 4, 2025 20:47
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Sep 4, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 4, 2025
@kodiakhq kodiakhq bot merged commit 1990362 into develop Sep 4, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the refactor/permissionsTable branch September 4, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants