Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Sep 4, 2025

Proposed changes (including videos or screenshots)

Previously we had mouseEnter and mouseLeave event to display the text in the permission cells, causing a conflict with the tooltip handler. So this PR aims to replace the events with an CSS addition to display the text on hovering the row

Depends on: #36872

before

Kapture 2025-09-04 at 12 02 14

after

Kapture 2025-09-04 at 12 04 11

Issue(s)

Steps to test or reproduce

Further comments

CORE-1323

@dougfabris dougfabris added this to the 7.11.0 milestone Sep 4, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 4, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 14344cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.15%. Comparing base (de54db1) to head (14344cb).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36870      +/-   ##
===========================================
- Coverage    66.17%   66.15%   -0.03%     
===========================================
  Files         3339     3338       -1     
  Lines       113419   113457      +38     
  Branches     21146    21119      -27     
===========================================
- Hits         75059    75056       -3     
- Misses       35676    35710      +34     
- Partials      2684     2691       +7     
Flag Coverage Δ
e2e 57.70% <66.66%> (+0.02%) ⬆️
unit 70.87% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review September 4, 2025 16:35
@dougfabris dougfabris requested a review from a team as a code owner September 4, 2025 16:35
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Sep 5, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 5, 2025
@kodiakhq kodiakhq bot merged commit 84df8b6 into develop Sep 5, 2025
85 of 87 checks passed
@kodiakhq kodiakhq bot deleted the fix/permission-tooltip branch September 5, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants