fix: Export Messages tab closing due to "flex-tab close when click outside of it" preference #36812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: e89622e The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36812 +/- ##
===========================================
+ Coverage 65.93% 66.34% +0.40%
===========================================
Files 3244 3322 +78
Lines 110055 111287 +1232
Branches 20778 21093 +315
===========================================
+ Hits 72566 73831 +1265
+ Misses 34867 34771 -96
- Partials 2622 2685 +63
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…hat/Rocket.Chat into fix/export-message-hide-flex-tab
dougfabris
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
What’s Changed
This PR fixes an issue where the Export Messages tab was being closed automatically when the user clicked outside of it. The behavior was tied to the user preference “Hide Contextual Bar by clicking outside of it”, but in this case, it caused a poor user experience during the export flow.
The goal is to ensure that the Export Messages tab remains open until the user explicitly closes it, providing a more consistent and reliable export process.
Testing
Remove
failfrom test introduced here: #36564Issue(s)
Steps to test or reproduce
Further comments
CORE-1259