-
Notifications
You must be signed in to change notification settings - Fork 13k
test: export messages with hide contextual bar preference #36564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36564 +/- ##
===========================================
- Coverage 65.89% 65.82% -0.07%
===========================================
Files 3190 3191 +1
Lines 106742 106733 -9
Branches 20312 20315 +3
===========================================
- Hits 70335 70259 -76
- Misses 33733 33815 +82
+ Partials 2674 2659 -15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Created an automated test to reproduce and validate the bug where clicking a message in the Export Messages dialog causes it to close when the "Hide Contextual Bar by clicking outside it" preference is enabled.
This test will serve as a check once the underlying issue is fixed.
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-1259
Steps to test or reproduce
Further comments
This test is intended to fail until the associated bug is fixed.
Once the fix is applied, this test can be used to verify that the dialog behavior is correct and stable going forward.