Skip to content

Conversation

@jessicaschelly
Copy link
Member

@jessicaschelly jessicaschelly commented Jul 29, 2025

Proposed changes (including videos or screenshots)

Created an automated test to reproduce and validate the bug where clicking a message in the Export Messages dialog causes it to close when the "Hide Contextual Bar by clicking outside it" preference is enabled.
This test will serve as a check once the underlying issue is fixed.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1259

Steps to test or reproduce

  1. Ensure the user preference "Hide Contextual Bar by clicking outside it" is enabled.
  2. Navigate to any room or DM and trigger the Export Messages dialog.
  3. Attempt to click/select a single message within the dialog.
  4. The test verifies that the dialog does not close upon message selection.

Further comments

This test is intended to fail until the associated bug is fixed.

Once the fix is applied, this test can be used to verify that the dialog behavior is correct and stable going forward.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 29, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2025

⚠️ No Changeset found

Latest commit: 6106cfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36564/

Built to branch gh-pages at 2025-07-31 13:20 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.82%. Comparing base (759b178) to head (6106cfa).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36564      +/-   ##
===========================================
- Coverage    65.89%   65.82%   -0.07%     
===========================================
  Files         3190     3191       +1     
  Lines       106742   106733       -9     
  Branches     20312    20315       +3     
===========================================
- Hits         70335    70259      -76     
- Misses       33733    33815      +82     
+ Partials      2674     2659      -15     
Flag Coverage Δ
e2e 57.88% <ø> (+<0.01%) ⬆️
unit 71.12% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jessicaschelly jessicaschelly marked this pull request as ready for review July 30, 2025 13:54
@jessicaschelly jessicaschelly requested a review from a team as a code owner July 30, 2025 13:54
@jessicaschelly jessicaschelly added this to the 7.10.0 milestone Jul 30, 2025
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jul 31, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 31, 2025
@kodiakhq kodiakhq bot merged commit 0ca189f into develop Jul 31, 2025
48 of 49 checks passed
@kodiakhq kodiakhq bot deleted the test/export-messages-hide-context branch July 31, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants