-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: prevent unhandled promise rejection if app has compiler error on startup #36802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 85dcd23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36802 +/- ##
===========================================
- Coverage 66.12% 66.11% -0.01%
===========================================
Files 3302 3302
Lines 110951 110951
Branches 21044 21042 -2
===========================================
- Hits 73364 73359 -5
- Misses 34916 34918 +2
- Partials 2671 2674 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Fixes an unhandled promise rejection crash that would happen during server startup if any of the apps installed had a compile error.
Issue(s)
Steps to test or reproduce
Further comments
CORE-1255
This PR keeps the solution simple in order to be "backportable". A proper refactor is implemented in #36803