Skip to content

fix: prevent unhandled promise rejection if app has compiler error on startup #36802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 2 commits into from
Aug 27, 2025
Merged

fix: prevent unhandled promise rejection if app has compiler error on startup #36802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
303fd32
Fix unhandled promise rejection when compilation error happens during
d-gubert Aug 26, 2025
85dcd23
Add changeset
d-gubert Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/polite-students-lick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@rocket.chat/apps-engine': patch
'@rocket.chat/meteor': patch
---

Fixes an error on apps loading that would cause an unhandled promise rejection crash during startup in some cases
4 changes: 4 additions & 0 deletions packages/apps-engine/src/server/AppManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,10 @@ export class AppManager {
getStatus() {
return Promise.resolve(AppStatus.COMPILER_ERROR_DISABLED);
},

on(): void {
return undefined;
},
} as unknown as DenoRuntimeSubprocessController);

this.apps.set(item.id, prl);
Expand Down
Loading