test: expect to be visible before focus in video-conference

[dougfabris]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

FLAKY-1424

Summary by CodeRabbit

• Bug Fixes

  • Ensured the video conference popup consistently appears above other page content by adjusting its overlay layering.

• Tests

  • Enhanced end-to-end test to verify the popup opens via keyboard and displays the correct “Start a call in ” message, ensuring visibility and accuracy.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2c7b386

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.54%. Comparing base (00611ac) to head (2c7b386).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #36789      +/-   ##
===========================================
+ Coverage    66.53%   66.54%   +0.01%     
===========================================
  Files         3344     3345       +1     
  Lines       114629   114629              
  Branches     21093    21167      +74     
===========================================
+ Hits         76271    76285      +14     
+ Misses       35665    35662       -3     
+ Partials      2693     2682      -11     

Flag	Coverage Δ
e2e	57.70% <ø> (+0.01%)	⬆️
unit	71.25% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Walkthrough

Adds an E2E test assertion to verify popup text visibility and updates the VideoConf popup backdrop to set zIndex=99. No public APIs or control flow changed.

Changes

Cohort / File(s)	Summary
E2E test assertion update apps/meteor/tests/e2e/video-conference.spec.ts	Adds an assertion checking the popup shows exact text "Start a call in " and is visible after keyboard-triggered opening.
UI backdrop z-index tweak packages/ui-video-conf/src/VideoConfPopup/VideoConfPopupBackdrop.tsx	Passes zIndex={99} to the Box alongside existing props; no signature or behavior changes beyond stacking order.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• tassoevan

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title accurately and concisely describes the main change: a test asserting visibility behavior in the video-conference area ("expect to be visible before focus"), uses the "test:" prefix, and references the affected feature without noisy extras. It is specific enough for a reviewer to understand the PR is a focused test change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Poem

A hop and a pop, z-index to the top,
The backdrop stands tall, no elements to flop.
Tests now peek with a careful stare—
“Start a call” exactly there.
Thump-thump goes QA’s gentle beat,
Bugs beware of rabbit feet! 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch test/videoconf-mic-button

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

apps/meteor/tests/e2e/video-conference.spec.ts (2)

34-40: Make the visibility assertion resilient to i18n/copy changes

Relying on exact English text may flake in localized runs. Prefer role- or test-id–based locators (e.g., dialog name, data-qa) or a regex/partial match anchored by channel name.

- await expect(poHomeChannel.content.getVideoConfPopup(`Start a call in ${targetChannel}`)).toBeVisible();
+ // Example options (pick what's available in the app):
+ // By role + accessible name:
+ // await expect(page.getByRole('dialog', { name: new RegExp(`${targetChannel}`, 'i') })).toBeVisible();
+ // Or by test id:
+ // await expect(page.getByTestId('video-conf-popup')).toBeVisible();

---

35-40: Nit: current checks don’t prove “visible before focus” ordering

This validates final state (visible + focused) but not that visibility preceded focus. If order matters for a11y, consider capturing focus events or awaiting visibility before the focusable is mounted/focused.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 00611ac and 2c7b386.

⛔ Files ignored due to path filters (1)

• packages/ui-video-conf/src/VideoConfPopup/__snapshots__/VideoConfPopup.spec.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

• apps/meteor/tests/e2e/video-conference.spec.ts (1 hunks)
• packages/ui-video-conf/src/VideoConfPopup/VideoConfPopupBackdrop.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: 📦 Build Packages
• GitHub Check: CodeQL-Build
• GitHub Check: CodeQL-Build

🔇 Additional comments (1)

packages/ui-video-conf/src/VideoConfPopup/VideoConfPopupBackdrop.tsx (1)

18-20: Avoid magic z-index; use a theme token or verify overlay order

Hardcoding zIndex={99} risks stacking collisions — the repo scan you ran returned no matches for a global z-index/layer token, so I couldn't confirm an existing value to reuse. Replace zIndex={99} with a theme token or CSS variable (or add a documented layer token) and ensure this value sits above other overlays.

Location: packages/ui-video-conf/src/VideoConfPopup/VideoConfPopupBackdrop.tsx (lines 18–20).