Skip to content

test: expect to be visible before focus in video-conference #36789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 7 commits into from
Sep 12, 2025
Merged

test: expect to be visible before focus in video-conference #36789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
682df69
test: bring video-conf backdrop to the front
dougfabris Aug 25, 2025
2fac197
test: update unit
dougfabris Aug 26, 2025
ce09eb7
Merge branch 'develop' into test/videoconf-mic-button
kodiakhq[bot] Aug 26, 2025
5afc6c8
Merge branch 'develop' into test/videoconf-mic-button
dougfabris Sep 2, 2025
471455e
Merge branch 'develop' into test/videoconf-mic-button
dougfabris Sep 5, 2025
460a300
chore: make sure dialog is visible
dougfabris Sep 8, 2025
2c7b386
Merge branch 'develop' into test/videoconf-mic-button
kodiakhq[bot] Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/meteor/tests/e2e/video-conference.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ test.describe('video conference', () => {
await page.keyboard.press('Tab');
await page.keyboard.press('Space');

await expect(poHomeChannel.content.getVideoConfPopup(`Start a call in ${targetChannel}`)).toBeVisible();
await expect(poHomeChannel.content.btnVideoConfMic).toBeFocused();
});

Expand Down
2 changes: 1 addition & 1 deletion packages/ui-video-conf/src/VideoConfPopup/VideoConfPopupBackdrop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const backdropStyle = css`
`;

const VideoConfPopupBackdrop = ({ children }: { children: ReactNode }): ReactElement => (
<Box m={40} className={backdropStyle}>
<Box m={40} zIndex={99} className={backdropStyle}>
{children}
</Box>
);
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-video-conf/src/VideoConfPopup/__snapshots__/VideoConfPopup.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing

exports[`renders StartCall without crashing 1`] = `
<body>
<div>
<div
class="rcx-box rcx-box--full rcx-css-11d1wak rcx-css-tzpx07"
class="rcx-box rcx-box--full rcx-css-11d1wak rcx-css-veoob9"
>
<div
aria-label="Start Call"
Expand Down
Loading