fix: Always broadcast deleted message #36683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: eec362e The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36683 +/- ##
===========================================
+ Coverage 66.34% 66.36% +0.02%
===========================================
Files 3324 3324
Lines 111339 111327 -12
Branches 21083 21085 +2
===========================================
+ Hits 73866 73882 +16
+ Misses 34783 34760 -23
+ Partials 2690 2685 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
abhinavkrin
previously approved these changes
Aug 19, 2025
dougfabris
requested changes
Aug 19, 2025
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
Even if "Message removed" isn't selected the system message are being removed
yash-rajpal
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dougfabris
approved these changes
Aug 20, 2025
abhinavkrin
previously approved these changes
Aug 20, 2025
dougfabris
requested changes
Aug 20, 2025
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
I still have doubts about the behavior
dionisio-bot
bot
removed
the
stat: ready to merge
dionisio-bot
bot
added
the
stat: ready to merge
dougfabris
approved these changes
Sep 2, 2025
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
LGTM! Agreed we'll check the overall reactivity in a separated work
yash-rajpal
removed
the
stat: QA assured
dionisio-bot
bot
removed
the
stat: ready to merge
dougfabris
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dougfabris
approved these changes
Sep 3, 2025
abhinavkrin
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Introduced here: #32522
Issue(s)
Steps to test or reproduce
Further comments
SUP-800