Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-months-kick.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes an issue where deleted messages remain visible until a manual page refresh when "Message removed" is hidden in hidden system messages settings.
4 changes: 4 additions & 0 deletions apps/meteor/server/lib/systemMessage/hideSystemMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,9 @@ export const shouldHideSystemMessage = (messageType: MessageTypesValues, hideSys
return false;
}

if (messageType === 'rm') {
return false;
}

return hideSystemMessage.includes(messageType) || (isMutedUnmuted(messageType) && hideSystemMessage.includes('mute_unmute'));
};
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ describe('hideSystemMessage', () => {
expect(result).to.be.false;
});

it('should return false if message type is of deleted message', async () => {
const result = shouldHideSystemMessage('rm', undefined);
expect(result).to.be.false;
});

it('should return false if hidden system messages are undefined', async () => {
const result = shouldHideSystemMessage('user-muted', undefined);
expect(result).to.be.false;
Expand Down
Loading