fix: desktop notifications implementing privacy settings #36503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cd78879 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
abhinavkrin
force-pushed
the
revert-36156-fix/desktop-notifications-not-respecting-privacy-settings
branch
from
911e06f to
937fbd2
Compare
Contributor
|
abhinavkrin
force-pushed
the
revert-36156-fix/desktop-notifications-not-respecting-privacy-settings
branch
from
937fbd2 to
c054cb4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-7.9.0 #36503 +/- ##
=================================================
- Coverage 65.70% 65.44% -0.26%
=================================================
Files 3174 3092 -82
Lines 105842 104283 -1559
Branches 20102 19720 -382
=================================================
- Hits 69539 68244 -1295
+ Misses 33624 33430 -194
+ Partials 2679 2609 -70
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
tassoevan
previously approved these changes
Jul 23, 2025
MarcosSpessatto
previously approved these changes
Jul 24, 2025
MartinSchoeler
previously approved these changes
Jul 24, 2025
KevLehman
reviewed
Jul 24, 2025
| window.focus(); | ||
|
|
||
| const jump = msgId && { jump: msgId }; | ||
| if (!notification.payload._id || !notification.payload.rid || !notification.payload.name) { |
Member
There was a problem hiding this comment.
You removed _id and name from the destructing but still being in use here.
Also, rid is already destructured and you're accessing it from the full path.
Member
Author
There was a problem hiding this comment.
It is a revert of a previous PR. Since earlier case was also working fine I didnt change anything in the revert PR.
| pattern: '/direct/:rid/:tab?/:context?', | ||
| params: { | ||
| rid, | ||
| rid: notification.payload.rid, |
Member
There was a problem hiding this comment.
Why not use the destructured rid?
| pattern: '/live/:id/:tab?/:context?', | ||
| params: { | ||
| id: rid, | ||
| id: notification.payload.rid, |
ggazzo
requested changes
Jul 24, 2025
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
this is not a regression, it should have changeset and be backported also btw
FragaKrummenauer
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
abhinavkrin
dismissed stale reviews from MartinSchoeler, MarcosSpessatto, and tassoevan
via
d9873cd
abhinavkrin
requested review from
KevLehman,
MarcosSpessatto,
MartinSchoeler,
ggazzo and
tassoevan
ggazzo
reviewed
Jul 25, 2025
ggazzo
changed the title
ggazzo
deleted the
revert-36156-fix/desktop-notifications-not-respecting-privacy-settings
branch
Member
|
/patch |
dionisio-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Contributor
|
Pull request #36545 added to Project: "Patch 7.8.3" |
Contributor
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #36156
CORE-1249