-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: desktop notifications not respecting privacy settings #36156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: desktop notifications not respecting privacy settings #36156
Conversation
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b644f4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36156 +/- ##
===========================================
- Coverage 64.39% 64.37% -0.02%
===========================================
Files 3142 3145 +3
Lines 104891 105141 +250
Branches 19791 20007 +216
===========================================
+ Hits 67543 67689 +146
- Misses 34667 34761 +94
- Partials 2681 2691 +10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
gabriellsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Front-End LGTM!
Proposed changes (including videos or screenshots)
This PR resolves an issue where the
Show Message in NotificationandShow Channel/Group/Username in Notificationsettings were not respected in desktop notifications.Key updates:
Screen.Recording.2025-06-05.at.11.02.59.PM.mov
Issue(s)
Steps to test or reproduce
Further comments
SUP-781