Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jul 21, 2025

Proposed changes (including videos or screenshots)

This pull request addresses a test failure by fixing and enhancing the UserAndRoomAutoCompleteMultiple.spec.tsx test suite. The changes improve test coverage and reliability.

Issue(s)

CORE-1304

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.10.0, but it targets 7.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2025

⚠️ No Changeset found

Latest commit: 64b3396

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36484/

Built to branch gh-pages at 2025-07-21 18:58 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.68%. Comparing base (960a914) to head (64b3396).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36484      +/-   ##
===========================================
+ Coverage    65.38%   65.68%   +0.29%     
===========================================
  Files         3191     3174      -17     
  Lines       106414   105831     -583     
  Branches     20257    20177      -80     
===========================================
- Hits         69581    69517      -64     
+ Misses       34130    33634     -496     
+ Partials      2703     2680      -23     
Flag Coverage Δ
e2e 58.07% <ø> (+0.31%) ⬆️
unit 70.83% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tiagoevanp tiagoevanp marked this pull request as ready for review July 21, 2025 21:29
@tiagoevanp tiagoevanp requested a review from a team as a code owner July 21, 2025 21:29
@ggazzo ggazzo added this to the 7.10.0 milestone Jul 25, 2025
@ggazzo ggazzo merged commit cc95107 into develop Jul 25, 2025
49 checks passed
@ggazzo ggazzo deleted the test/users-and-room-auto-complete-multiple branch July 25, 2025 12:23
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants