-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Remove deprecated flag of MessageActionConfig
#36476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated color property from the MessageActionConfig type and updates existing references to use the newer variant property instead. The changes ensure consistency in the codebase by eliminating the deprecated flag pattern.
- Removed the deprecated
color?: 'alert'property fromMessageActionConfigtype definition - Updated message action hooks to use
variant: 'danger'instead ofcolor: 'alert' - Simplified conditional logic in toolbar components to directly use the
variantproperty
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MessageAction.ts | Removes deprecated color property from MessageActionConfig type |
| useReportMessageAction.tsx | Updates report action to use variant: 'danger' instead of deprecated color: 'alert' |
| useDeleteMessageAction.ts | Updates delete action to use variant: 'danger' instead of deprecated color: 'alert' |
| MessageToolbarStarsActionMenu.tsx | Simplifies logic to use variant directly instead of checking color |
| MessageToolbarActionMenu.tsx | Simplifies logic to use variant directly instead of checking color |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36476 +/- ##
========================================
Coverage 65.69% 65.70%
========================================
Files 3174 3174
Lines 105831 105827 -4
Branches 20100 20067 -33
========================================
+ Hits 69524 69531 +7
+ Misses 33635 33624 -11
Partials 2672 2672
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
ARCH-1722
Steps to test or reproduce
Further comments