Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 20, 2025

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1722

Steps to test or reproduce

Further comments

@tassoevan tassoevan added this to the 7.9.0 milestone Jul 20, 2025
@tassoevan tassoevan requested a review from a team as a code owner July 20, 2025 03:19
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 20, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2025

⚠️ No Changeset found

Latest commit: 9697ebd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan requested a review from Copilot July 20, 2025 03:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated color property from the MessageActionConfig type and updates existing references to use the newer variant property instead. The changes ensure consistency in the codebase by eliminating the deprecated flag pattern.

  • Removed the deprecated color?: 'alert' property from MessageActionConfig type definition
  • Updated message action hooks to use variant: 'danger' instead of color: 'alert'
  • Simplified conditional logic in toolbar components to directly use the variant property

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
MessageAction.ts Removes deprecated color property from MessageActionConfig type
useReportMessageAction.tsx Updates report action to use variant: 'danger' instead of deprecated color: 'alert'
useDeleteMessageAction.ts Updates delete action to use variant: 'danger' instead of deprecated color: 'alert'
MessageToolbarStarsActionMenu.tsx Simplifies logic to use variant directly instead of checking color
MessageToolbarActionMenu.tsx Simplifies logic to use variant directly instead of checking color

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36476/

Built to branch gh-pages at 2025-07-22 22:00 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (9314e66) to head (9697ebd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36476   +/-   ##
========================================
  Coverage    65.69%   65.70%           
========================================
  Files         3174     3174           
  Lines       105831   105827    -4     
  Branches     20100    20067   -33     
========================================
+ Hits         69524    69531    +7     
+ Misses       33635    33624   -11     
  Partials      2672     2672           
Flag Coverage Δ
e2e 58.07% <ø> (-0.05%) ⬇️
unit 70.85% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 21, 2025
@kodiakhq kodiakhq bot merged commit 91fb559 into develop Jul 22, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/message-action-config-color branch July 22, 2025 22:42
4rch50nist pushed a commit to 4rch50nist/Rocket.Chat that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants