Skip to content

chore: Remove deprecated flag of MessageActionConfig #36476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 3 commits into from
Jul 22, 2025
Merged

chore: Remove deprecated flag of MessageActionConfig #36476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6382679
chore: Remove deprecated flag of `MessageActionConfig`
tassoevan Jul 20, 2025
4adb381
Merge branch 'develop' into chore/message-action-config-color
kodiakhq[bot] Jul 21, 2025
9697ebd
Merge branch 'develop' into chore/message-action-config-color
kodiakhq[bot] Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/meteor/app/ui-utils/client/lib/MessageAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ export type MessageActionConfig = {
variant?: 'danger' | 'success' | 'warning';
label: TranslationKey;
order: number;
/** @deprecated */
color?: 'alert';
group: MessageActionGroup;
context?: MessageActionContext[];
action: (e: Pick<Event, 'preventDefault' | 'stopPropagation' | 'currentTarget'> | undefined) => any;
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/client/components/message/toolbar/MessageToolbarActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const MessageToolbarActionMenu = ({ message, context, room, subscription, onChan

const groupOptions = [...data, ...(actionButtonApps.data ?? [])]
.map((option) => ({
variant: option.color === 'alert' ? 'danger' : '',
variant: option.variant,
id: option.id,
icon: option.icon,
content: t(option.label),
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/client/components/message/toolbar/MessageToolbarStarsActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const MessageToolbarStarsActionMenu = ({ message, context, onChangeMenuVisibilit

const groupOptions = starsAction.data.reduce((acc, option) => {
const transformedOption = {
variant: option.color === 'alert' ? 'danger' : '',
variant: option.variant,
id: option.id,
icon: option.icon,
content: t(option.label),
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/client/components/message/toolbar/useDeleteMessageAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const useDeleteMessageAction = (
icon: 'trash',
label: 'Delete',
context: ['message', 'message-mobile', 'threads', 'federated', 'videoconf', 'videoconf-threads'],
color: 'alert',
variant: 'danger',
type: 'management',
async action() {
await chat?.flows.requestMessageDeletion(message);
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/client/components/message/toolbar/useReportMessageAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const useReportMessageAction = (
icon: 'report',
label: 'Report',
context: ['message', 'message-mobile', 'threads', 'federated', 'videoconf', 'videoconf-threads'],
color: 'alert',
variant: 'danger',
type: 'management',
action() {
setModal(
Expand Down
Loading