-
Notifications
You must be signed in to change notification settings - Fork 13k
refactor: GenericUpsellModal to use GenericModal #36347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
8dc57e9 to
79823fd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36347 +/- ##
===========================================
+ Coverage 64.88% 64.92% +0.04%
===========================================
Files 3154 3156 +2
Lines 104741 104824 +83
Branches 19935 19925 -10
===========================================
+ Hits 67957 68061 +104
+ Misses 34099 34081 -18
+ Partials 2685 2682 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dougfabris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Proposed changes (including videos or screenshots)
This PR refactors
GenericUpsellModalto useGenericModalinternally, reducing code duplication and making future maintenance easier.It also improves the Storybook stories and adds unit tests to ensure component reliability.
Issue(s)
CTZ-199
Steps to test or reproduce
Further comments