feat: Added imgAlt, imgWidth and imgHeight props to GenericUpsellModal

[aleksandernsilva]

Proposed changes (including videos or screenshots)

This PR delivers improvements to the GenericUpsellModal components, the changes are:

• Added imgAlt, imgWidth, and imgHeight optional props to the GenericUpsellModal for improved image accessibility and flexibility.
• Added unit tests for the updated GenericUpsellModal.

Issue(s)

CTZ-199

Steps to test or reproduce

I believe the easiest way to test these changes is by running our storybook yarn storybook and searching for GenericUpsellModal.

Further comments

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 06966b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/http-router	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.6.2
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36333/
Built to branch gh-pages at 2025-07-08 16:03 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.78%. Comparing base (c39ccb5) to head (06966b4).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #36333      +/-   ##
===========================================
+ Coverage    64.75%   64.78%   +0.03%     
===========================================
  Files         3156     3156              
  Lines       104879   104916      +37     
  Branches     19956    19962       +6     
===========================================
+ Hits         67915    67971      +56     
+ Misses       34284    34262      -22     
- Partials      2680     2683       +3     

Flag	Coverage Δ
e2e	57.63% <33.33%> (+0.03%)	⬆️
unit	69.50% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dougfabris]

what do you think about some snapshot and a11y tests, for these stories?

[dougfabris]

since GenericUpsellModal is an extension of GenericModal I have a feeling that these tests regarding events (onClose, onCancel, onConfirm) should be GenericModal tests, don't you?

[aleksandernsilva]

since GenericUpsellModal is an extension of GenericModal I have a feeling that these tests regarding events (onClose, onCancel, onConfirm) should be GenericModal tests, don't you?

@dougfabris Funny enough, it currently does not use the GenericModal internally 😑 To keep things separate I opened #36347 to refactor the Upsell modal. This one I will rebase and keep only the img props changes.

[dougfabris]

LGTM!

[dougfabris]

just missing the changeset