Skip to content

Conversation

@ahmed-n-abdeltwab
Copy link
Contributor

Refactor ExtractRoutesFromAPI for the APIClass POST method.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 19, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2025

⚠️ No Changeset found

Latest commit: f2951bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ahmed-n-abdeltwab ahmed-n-abdeltwab changed the title Refactor: Improve ExtractRoutesFromAPI for Route Conversions. refactor: improve ExtractRoutesFromAPI for Route Conversions. Jun 19, 2025
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.33%. Comparing base (d9f0fba) to head (f2951bb).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36246      +/-   ##
===========================================
- Coverage    64.83%   63.33%   -1.51%     
===========================================
  Files         3153     3098      -55     
  Lines       104795   103724    -1071     
  Branches     19962    19708     -254     
===========================================
- Hits         67945    65694    -2251     
- Misses       34164    35520    +1356     
+ Partials      2686     2510     -176     
Flag Coverage Δ
e2e 52.51% <ø> (-5.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ahmed-n-abdeltwab ahmed-n-abdeltwab changed the title refactor: improve ExtractRoutesFromAPI for Route Conversions. refactor: improve ExtractRoutesFromAPI for Route Conversions Jun 19, 2025
Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@cardoso cardoso added the stat: QA assured Means it has been tested and approved by a company insider label Jun 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2025
@cardoso cardoso force-pushed the fix/extract-routes-from-api branch from 8c8f142 to 9ece239 Compare June 20, 2025 11:09
@cardoso cardoso removed this from the 7.8.0 milestone Jun 20, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2025
@cardoso cardoso added this to the 7.9.0 milestone Jun 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 24, 2025
@kodiakhq kodiakhq bot merged commit 4c2a437 into RocketChat:develop Jun 24, 2025
82 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gsoc-project stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants