-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Add OpenAPI Support to chat.postMessage API #36090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Add OpenAPI Support to chat.postMessage API #36090
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: d94a574 The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey, @cardoso, the Rocket.Chat/apps/meteor/app/api/server/v1/chat.ts Lines 466 to 472 in a9e1f46
|
…tesFromAPI utilities.
…and type assertions
372a6e6 to
e336a45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36090 +/- ##
===========================================
- Coverage 65.44% 61.22% -4.23%
===========================================
Files 3168 2718 -450
Lines 104982 97617 -7365
Branches 19991 18248 -1743
===========================================
- Hits 68709 59769 -8940
- Misses 33598 35915 +2317
+ Partials 2675 1933 -742
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@cardoso, I think this is going to work now. I tested it locally, and everything looks good. |
|
this pr need an update |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description:
This PR integrates OpenAPI support into the
Rocket.Chat API, migrate ofRocket.Chat APIendpoints to the new OpenAPI pattern. The update includes improved API documentation, enhanced type safety, and response validation using AJV.Key Changes:
Issue Reference:
Relates to #34983, part of the ongoing OpenAPI integration effort.
Testing:
Endpoints:
Looking forward to your feedback! 🚀