Skip to content

Conversation

@cardoso
Copy link
Member

@cardoso cardoso commented Jun 18, 2025

Follow up to #36206 .

Fixes the bug in a more reliable way and enables the e2e test. It runs in 20 seconds and hasn't been flaky so far.

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1079

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 18, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2025

🦋 Changeset detected

Latest commit: 59a81e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-voip Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/http-router Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36244/

Built to branch gh-pages at 2025-06-20 15:39 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 26.76056% with 52 lines in your changes missing coverage. Please review.

Project coverage is 64.52%. Comparing base (a87f9e0) to head (59a81e8).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.8.0   #36244      +/-   ##
=================================================
- Coverage          64.59%   64.52%   -0.07%     
=================================================
  Files               3147     3148       +1     
  Lines             104580   104620      +40     
  Branches           19770    19762       -8     
=================================================
- Hits               67553    67511      -42     
- Misses             34345    34422      +77     
- Partials            2682     2687       +5     
Flag Coverage Δ
e2e 57.60% <30.18%> (-0.08%) ⬇️
unit 69.11% <11.11%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cardoso cardoso marked this pull request as ready for review June 19, 2025 11:45
@cardoso cardoso requested review from a team as code owners June 19, 2025 11:45
@cardoso cardoso force-pushed the test/status-overlapping-events branch 2 times, most recently from c960af9 to ed75ca2 Compare June 20, 2025 03:30
@cardoso cardoso added the stat: QA assured Means it has been tested and approved by a company insider label Jun 20, 2025
@cardoso cardoso added this to the 7.8.0 milestone Jun 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2025
@cardoso cardoso force-pushed the test/status-overlapping-events branch from ed75ca2 to 9285489 Compare June 20, 2025 15:09
@cardoso cardoso marked this pull request as draft June 20, 2025 15:12
@cardoso cardoso removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Jun 20, 2025
@cardoso cardoso changed the base branch from develop to release-7.8.0 June 20, 2025 15:27
@cardoso cardoso force-pushed the test/status-overlapping-events branch from 9285489 to 59a81e8 Compare June 20, 2025 15:27
@cardoso cardoso closed this Jun 20, 2025
@cardoso cardoso deleted the test/status-overlapping-events branch June 20, 2025 15:42
@cardoso cardoso removed this from the 7.8.0 milestone Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants