Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jun 20, 2025

Proposed changes (including videos or screenshots)

Introduces a different format to export room messages, export as PDF.

It was not possible to include new tests with the specific action perform (e2e) nor functional tests

Issue(s)

Steps to test or reproduce

Further comments

CORE-1080

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 20, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2025

🦋 Changeset detected

Latest commit: 3e0e494

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-voip Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/http-router Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tiagoevanp tiagoevanp added this to the 7.8.0 milestone Jun 20, 2025
@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36259/

Built to branch gh-pages at 2025-06-20 05:34 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 32.07547% with 36 lines in your changes missing coverage. Please review.

Project coverage is 64.53%. Comparing base (c992f7d) to head (3e0e494).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36259      +/-   ##
===========================================
- Coverage    64.57%   64.53%   -0.04%     
===========================================
  Files         3147     3148       +1     
  Lines       104580   104625      +45     
  Branches     19763    19771       +8     
===========================================
- Hits         67532    67522      -10     
- Misses       34365    34413      +48     
- Partials      2683     2690       +7     
Flag Coverage Δ
e2e 57.60% <30.18%> (-0.07%) ⬇️
unit 69.14% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tiagoevanp tiagoevanp added the stat: QA assured Means it has been tested and approved by a company insider label Jun 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2025
@tiagoevanp tiagoevanp marked this pull request as ready for review June 20, 2025 11:34
@tiagoevanp tiagoevanp requested review from a team as code owners June 20, 2025 11:34
@scuciatto
Copy link
Member

Could you please add a description to the PR?

@kodiakhq kodiakhq bot merged commit 4ec3b92 into develop Jun 20, 2025
52 checks passed
@kodiakhq kodiakhq bot deleted the feat/pdf-export branch June 20, 2025 13:36
@ggazzo ggazzo modified the milestones: 7.8.0, 7.9.0 Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants