fix: im/channels/groups.counters endpoint includes deactivated users in members count #36236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in members Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 4bbed28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Abhinav Kumar <[email protected]>
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36236 +/- ##
===========================================
- Coverage 64.39% 64.38% -0.02%
===========================================
Files 3145 3145
Lines 105137 105137
Branches 19874 19878 +4
===========================================
- Hits 67702 67689 -13
- Misses 34746 34753 +7
- Partials 2689 2695 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
10 tasks
MarcosSpessatto
suggested changes
Jun 18, 2025
Signed-off-by: Abhinav Kumar <[email protected]>
MarcosSpessatto
approved these changes
Jun 18, 2025
abhinavkrin
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
jeanfbrito
pushed a commit
that referenced
this pull request
Jun 18, 2025
…in members count (#36236)
This was referenced Jun 20, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The counters endpoint for channels, direct messages, and groups has been updated to exclude deactivated users. Moving forward this APIs will also be used to display the members count in the RoomActionView on mobile app.
Issue(s)
Steps to test or reproduce
Further comments
SUP-739