-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Correct logic of condition for sending LivechatSessionStarted webhook event
#36193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 5833ca3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36193 +/- ##
===========================================
+ Coverage 64.53% 64.56% +0.02%
===========================================
Files 3128 3128
Lines 98325 98325
Branches 18652 18653 +1
===========================================
+ Hits 63450 63479 +29
+ Misses 32051 32029 -22
+ Partials 2824 2817 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-813
Steps to test or reproduce
Further comments
Basic tests of events being fired when selected are there. We could use the same logic to test the actual payload being sent in the future.
Caused by #35970