refactor: Remove `afterTakeInquiry` callback #35970

KevLehman · 2025-05-12T14:54:22Z

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-117

Steps to test or reproduce

Further comments

This pull request refactors the handling of the afterTakeInquiry logic in the Rocket.Chat repository. The changes involve removing the generic callbacks.runAsync mechanism and replacing it with a direct function import and call. Specifically, the afterTakeInquiry function is now imported from ./hooks and called directly after an agent is assigned in the RoutingManager.ts file. Additionally, a new afterTakeInquiry function is added in hooks.ts to handle post-processing tasks, such as triggering a CRM webhook if configured. In the afterTakeInquiry.ts file within the livechat-enterprise module, the hook is refactored to use the .patch method instead of the legacy callbacks.add. This refactoring introduces new logic to manage last chatted agent routing, schedule auto-transfer for chats, and stop queue inactivity monitoring when an inquiry is taken, based on the respective feature settings.

dionisio-bot · 2025-05-12T14:54:27Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-05-12T14:54:27Z

⚠️ No Changeset found

Latest commit: f5f19ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kody-ai · 2025-05-12T14:54:29Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/ee/app/livechat-enterprise/server/hooks/afterTakeInquiry.ts

apps/meteor/app/livechat/server/lib/hooks.ts

github-actions · 2025-05-12T15:00:19Z

PR Preview Action v1.6.1
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35970/
Built to branch `gh-pages` at 2025-05-13 15:46 UTC. Preview will be ready when the GitHub Pages deployment is complete.

codecov · 2025-05-12T15:01:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.72%. Comparing base (fdb3b57) to head (f5f19ad).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35970      +/-   ##
===========================================
+ Coverage    64.68%   64.72%   +0.03%     
===========================================
  Files         3244     3244              
  Lines        95397    95393       -4     
  Branches     17855    17899      +44     
===========================================
+ Hits         61710    61739      +29     
+ Misses       30796    30761      -35     
- Partials      2891     2893       +2

Flag	Coverage Δ
e2e	`58.37% <ø> (+0.07%)`	⬆️
unit	`71.93% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kody-ai · 2025-05-12T17:14:09Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/ee/app/livechat-enterprise/server/lib/AutoTransferChatScheduler.ts

kody-ai · 2025-05-12T18:14:26Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/ee/app/livechat-enterprise/server/hooks/afterTakeInquiry.ts

apps/meteor/app/livechat/server/lib/hooks.ts

apps/meteor/ee/app/livechat-enterprise/server/hooks/afterTakeInquiry.ts

apps/meteor/ee/app/livechat-enterprise/server/lib/AutoTransferChatScheduler.ts

apps/meteor/app/livechat/server/lib/hooks.ts

Co-authored-by: Diego Sampaio <[email protected]>

kody-ai · 2025-05-13T01:26:36Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-13T13:52:13Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-13T14:00:22Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-13T14:09:51Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kody-ai · 2025-05-13T15:38:03Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

aftertakeinq

37d8888

KevLehman added this to the 7.7.0 milestone May 12, 2025

kody-ai bot reviewed May 12, 2025

View reviewed changes

apps/meteor/ee/app/livechat-enterprise/server/hooks/afterTakeInquiry.ts Show resolved Hide resolved

kody-ai bot reviewed May 12, 2025

View reviewed changes

apps/meteor/app/livechat/server/lib/hooks.ts Show resolved Hide resolved

aftertakeinq

208e7d3

kody-ai bot reviewed May 12, 2025

View reviewed changes

apps/meteor/ee/app/livechat-enterprise/server/lib/AutoTransferChatScheduler.ts Outdated Show resolved Hide resolved

aftertakeinq

fbab054

KevLehman marked this pull request as ready for review May 12, 2025 19:12

KevLehman requested a review from a team as a code owner May 12, 2025 19:12

KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label May 12, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 12, 2025

sampaiodiego requested changes May 12, 2025

View reviewed changes

Apply suggestions from code review

aadc33d

Co-authored-by: Diego Sampaio <[email protected]>

aftertakeinq

4f27a02

aftertakeinq

62bcb63

dum

ac5bc75

KevLehman requested a review from sampaiodiego May 13, 2025 14:11

sampaiodiego approved these changes May 13, 2025

View reviewed changes

Merge branch 'develop' into refactor/aftertakeinq

f5f19ad

kodiakhq bot merged commit a3cf891 into develop May 13, 2025
48 checks passed

kodiakhq bot deleted the refactor/aftertakeinq branch May 13, 2025 16:51

KevLehman mentioned this pull request Jun 10, 2025

fix: Correct logic of condition for sending LivechatSessionStarted webhook event #36193

Merged

refactor: Remove afterTakeInquiry callback #35970

refactor: Remove afterTakeInquiry callback #35970

Uh oh!

Conversation

KevLehman commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

kody-ai bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2025-05-13 15:46 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kody-ai bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

kody-ai bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kody-ai bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

kody-ai bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Completed! 🔥

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor: Remove `afterTakeInquiry` callback #35970

refactor: Remove `afterTakeInquiry` callback #35970

KevLehman commented May 12, 2025 •

edited

Loading

dionisio-bot bot commented May 12, 2025 •

edited

Loading

changeset-bot bot commented May 12, 2025 •

edited

Loading

kody-ai bot commented May 12, 2025 •

edited

Loading

github-actions bot commented May 12, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-05-13 15:46 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

codecov bot commented May 12, 2025 •

edited

Loading

kody-ai bot commented May 12, 2025 •

edited

Loading

kody-ai bot commented May 12, 2025 •

edited

Loading

kody-ai bot commented May 13, 2025 •

edited

Loading

kody-ai bot commented May 13, 2025 •

edited

Loading

kody-ai bot commented May 13, 2025 •

edited

Loading

kody-ai bot commented May 13, 2025 •

edited

Loading

kody-ai bot commented May 13, 2025 •

edited

Loading