-
Notifications
You must be signed in to change notification settings - Fork 13.1k
regression: Broken links in the UI when multiple links are used #36063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.7.0 #36063 +/- ##
=================================================
+ Coverage 64.74% 64.95% +0.21%
=================================================
Files 3110 3110
Lines 93179 93672 +493
Branches 17751 17801 +50
=================================================
+ Hits 60332 60848 +516
+ Misses 30059 30043 -16
+ Partials 2788 2781 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
3ce237c to
453c6ff
Compare
Proposed changes (including videos or screenshots)
Implements more test cases to ensure behaviour is correct.
Changes the regex that matches the URI schemes to not have the "global" property.
The issue was introduced here: #32917
For some reason, the change to the
inlineMarkedreturn is what broke the links. I did not find why that was the case, but reading domPurify's documentation and types, the default regex was found to not have theglobalproperty. Given the whole context, it was inferred that the issue happened due to regexes with the "global" flag set keeping an internal index after matching the text. If the same regex was being used to try to match multiple strings, some of them would not match due to the Regexe's dirty state.Issue(s)
CORE-1160
Steps to test or reproduce
Further comments