fix: External links without target not being modified #32917
Merged
+213
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 6658c2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32917 +/- ##
===========================================
+ Coverage 64.84% 64.87% +0.02%
===========================================
Files 3099 3099
Lines 92324 92346 +22
Branches 17629 17636 +7
===========================================
+ Hits 59871 59905 +34
+ Misses 29685 29679 -6
+ Partials 2768 2762 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
previously approved these changes
Aug 5, 2024
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
jeanfbrito
force-pushed
the
fix/i18n-external-links
branch
from
1930fbb to
78da2ff
Compare
Contributor
|
tassoevan
previously approved these changes
May 12, 2025
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tassoevan
force-pushed
the
fix/i18n-external-links
branch
from
1afcfed to
6658c2e
Compare
tassoevan
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Closes #32911
Steps to test or reproduce
Further comments
CORE-580
This pull request addresses an issue in the Rocket.Chat repository where external links in settings were not being modified to open in new tabs. The changes include adding a changeset entry to ensure that these links are correctly set to open in new tabs, enhancing user experience by preventing navigation away from the current page. The changes are made in the
fix/i18n-external-linksbranch and are intended to be merged into thedevelopbranch.