Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented May 15, 2025

Proposed changes (including videos or screenshots)

Fixes issue that caused all errors to be shown as [object, object] on the threads list

Issue(s)

CORE-1082

Steps to test or reproduce

  1. Do anything that would throw an error on the threads list (not-allowed, disabled, rate limiter, etc...)
  2. See the error callout showing [object, objecrt]

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 15, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2025

🦋 Changeset detected

Latest commit: ebf73b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36004/

Built to branch gh-pages at 2025-05-20 17:16 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.92%. Comparing base (49fd7c7) to head (ebf73b3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36004      +/-   ##
===========================================
+ Coverage    64.75%   64.92%   +0.17%     
===========================================
  Files         3110     3110              
  Lines        93181    93605     +424     
  Branches     17757    17805      +48     
===========================================
+ Hits         60340    60774     +434     
- Misses       30049    30050       +1     
+ Partials      2792     2781      -11     
Flag Coverage Δ
e2e 58.41% <ø> (-0.01%) ⬇️
unit 71.61% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gabriellsh and others added 3 commits May 15, 2025 17:55
Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
@MartinSchoeler MartinSchoeler marked this pull request as ready for review May 16, 2025 17:52
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner May 16, 2025 17:52
@scuciatto scuciatto added this to the 7.8.0 milestone May 19, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label May 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 20, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 20, 2025
@MartinSchoeler MartinSchoeler added the stat: ready to merge PR tested and approved waiting for merge label May 21, 2025
@kodiakhq kodiakhq bot merged commit aaf62dc into develop May 21, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the fix/object-error-threads branch May 21, 2025 19:37
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants