-
Notifications
You must be signed in to change notification settings - Fork 13.8k
fix: threadList showing errors as [object, object]
#36004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
548b996
fix: threadList showing errors as `[object, object]`
MartinSchoeler 1fab9b4
Create sour-pianos-glow.md
MartinSchoeler 18b6173
Merge branch 'develop' into fix/object-error-threads
gabriellsh e9bd114
test: threadList error state
MartinSchoeler 920ceae
Update .changeset/sour-pianos-glow.md
MartinSchoeler ef1dc8f
Merge branch 'develop' into fix/object-error-threads
MartinSchoeler 51d2016
review: update tests
MartinSchoeler e8103d7
review: add fallback value to geterrormessage()
MartinSchoeler 83b5863
review: fallback string change
MartinSchoeler bca87c2
Merge branch 'develop' into fix/object-error-threads
MartinSchoeler ebf73b3
Merge branch 'develop' into fix/object-error-threads
MartinSchoeler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@rocket.chat/meteor": patch | ||
| --- | ||
|
|
||
| fixes issue that caused errors on the threads list to be shown as `[object, Object]` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.