Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented May 9, 2025

https://rocketchat.atlassian.net/browse/ARCH-1605
finishes the job started here: #35948

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments


This pull request updates the Rocket.Chat API to use 'route' instead of 'path', enhancing consistency and maintainability. In definition.ts, a readonly route property is added to the PartialThis type to improve type safety. In parseJsonQuery.ts, the code is updated to use 'route' for API endpoint handling, with added deprecation logging and maintained security checks for query parameters. Additionally, in router.ts, a global interface declaration is removed, and request handling in the Router class is refactored to improve type safety and request processing.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: afb8c1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 9, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@kody-ai
Copy link

kody-ai bot commented May 9, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@ggazzo ggazzo changed the title chore: update API to use 'route' instead of 'path' chore: Update API to use 'route' instead of 'path' May 9, 2025
@ggazzo ggazzo added this to the 7.7.0 milestone May 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35956/

Built to branch gh-pages at 2025-05-13 19:00 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.73%. Comparing base (a3cf891) to head (afb8c1c).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35956      +/-   ##
===========================================
- Coverage    64.73%   64.73%   -0.01%     
===========================================
  Files         3244     3244              
  Lines        95393    95383      -10     
  Branches     17857    17887      +30     
===========================================
- Hits         61753    61742      -11     
- Misses       30752    30753       +1     
  Partials      2888     2888              
Flag Coverage Δ
e2e 58.37% <ø> (ø)
unit 71.95% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo force-pushed the chore/request-type branch from 00ce8d1 to 7e48563 Compare May 9, 2025 19:11
@kody-ai
Copy link

kody-ai bot commented May 13, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@ggazzo ggazzo marked this pull request as ready for review May 13, 2025 20:28
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label May 14, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 14, 2025
@ggazzo ggazzo merged commit 78cbade into develop May 14, 2025
51 checks passed
@ggazzo ggazzo deleted the chore/request-type branch May 14, 2025 14:45
ahmed-n-abdeltwab pushed a commit to ahmed-n-abdeltwab/Rocket.Chat that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants