-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Update API to use 'route' instead of 'path' #35956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Looks like this PR is ready to merge! 🎉 |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35956 +/- ##
===========================================
- Coverage 64.73% 64.73% -0.01%
===========================================
Files 3244 3244
Lines 95393 95383 -10
Branches 17857 17887 +30
===========================================
- Hits 61753 61742 -11
- Misses 30752 30753 +1
Partials 2888 2888
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
https://rocketchat.atlassian.net/browse/ARCH-1605
finishes the job started here: #35948
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This pull request updates the Rocket.Chat API to use 'route' instead of 'path', enhancing consistency and maintainability. In
definition.ts, a readonly route property is added to the PartialThis type to improve type safety. InparseJsonQuery.ts, the code is updated to use 'route' for API endpoint handling, with added deprecation logging and maintained security checks for query parameters. Additionally, inrouter.ts, a global interface declaration is removed, and request handling in the Router class is refactored to improve type safety and request processing.