Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented May 8, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1142

Steps to test or reproduce

Further comments

Introduced in #35078

Apparently, the other place we had to do this check was updated already, but this one was left on request.route instead of api.path.

Typings says request.route should be defined tho, but that's maybe because we're using global.Request instead of a Hono/Express custom one 👀

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 8, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2025

⚠️ No Changeset found

Latest commit: e7582ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman added this to the 7.6.0 milestone May 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35948/

Built to branch gh-pages at 2025-05-08 15:57 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.23%. Comparing base (976f7b3) to head (e7582ee).
Report is 1 commits behind head on release-7.6.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.6.0   #35948      +/-   ##
=================================================
+ Coverage          57.17%   61.23%   +4.05%     
=================================================
  Files               2446     3155     +709     
  Lines              63994    74644   +10650     
  Branches           14138    16680    +2542     
=================================================
+ Hits               36590    45706    +9116     
- Misses             25036    25836     +800     
- Partials            2368     3102     +734     
Flag Coverage Δ
e2e 58.08% <ø> (+11.71%) ⬆️
unit 74.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman marked this pull request as ready for review May 8, 2025 16:44
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label May 8, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 8, 2025
@kodiakhq kodiakhq bot merged commit 9a626ad into release-7.6.0 May 8, 2025
51 of 52 checks passed
@kodiakhq kodiakhq bot deleted the regression/use-apipath-instead-of-requestroute branch May 8, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants