Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 30, 2025

introduced here: #35787
https://rocketchat.atlassian.net/browse/ARCH-1587

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments


Pull Request Description

This pull request addresses a regression issue in the Rocket.Chat repository by modifying the logic used to determine when to close idle connections. Specifically, the change is made in the useIdleConnection.ts file within the apps/meteor/client/hooks directory. The updated logic now checks if the connection status is not 'offline' before disconnecting from the server, improving the condition for handling idle connections. The source branch for this change is regression/useIdleConnection, and it targets the develop branch.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 30, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.7.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: 2cf2590

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kody-ai
Copy link

kody-ai bot commented Apr 30, 2025

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@ggazzo ggazzo added this to the 7.6.0 milestone Apr 30, 2025
@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35912/

Built to branch gh-pages at 2025-04-30 14:27 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.16%. Comparing base (f5a05f3) to head (2cf2590).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35912      +/-   ##
===========================================
+ Coverage    61.15%   61.16%   +0.01%     
===========================================
  Files         3014     3014              
  Lines        71597    71596       -1     
  Branches     16398    16398              
===========================================
+ Hits         43782    43792      +10     
+ Misses       24845    24835      -10     
+ Partials      2970     2969       -1     
Flag Coverage Δ
e2e 57.88% <100.00%> (+0.02%) ⬆️
unit 75.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

juliajforesti
juliajforesti previously approved these changes Apr 30, 2025
@juliajforesti juliajforesti marked this pull request as ready for review April 30, 2025 14:38
@juliajforesti juliajforesti requested a review from a team as a code owner April 30, 2025 14:38
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Apr 30, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 30, 2025
@ggazzo ggazzo force-pushed the regression/useIdleConnection branch from fd3399b to 9d6b4ab Compare April 30, 2025 15:06
@kody-ai
Copy link

kody-ai bot commented Apr 30, 2025

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@ggazzo ggazzo removed the stat: QA assured Means it has been tested and approved by a company insider label Apr 30, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 30, 2025
@ggazzo ggazzo force-pushed the regression/useIdleConnection branch from 9d6b4ab to 2cf2590 Compare April 30, 2025 15:20
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Apr 30, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 30, 2025
@ggazzo ggazzo merged commit 4f0bc99 into develop Apr 30, 2025
52 checks passed
@ggazzo ggazzo deleted the regression/useIdleConnection branch April 30, 2025 17:29
ggazzo added a commit that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants