-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: close idle connections #35912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35912 +/- ##
===========================================
+ Coverage 61.15% 61.16% +0.01%
===========================================
Files 3014 3014
Lines 71597 71596 -1
Branches 16398 16398
===========================================
+ Hits 43782 43792 +10
+ Misses 24845 24835 -10
+ Partials 2970 2969 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
fd3399b to
9d6b4ab
Compare
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
9d6b4ab to
2cf2590
Compare
introduced here: #35787
https://rocketchat.atlassian.net/browse/ARCH-1587
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Pull Request Description
This pull request addresses a regression issue in the Rocket.Chat repository by modifying the logic used to determine when to close idle connections. Specifically, the change is made in the
useIdleConnection.tsfile within theapps/meteor/client/hooksdirectory. The updated logic now checks if the connection status is not 'offline' before disconnecting from the server, improving the condition for handling idle connections. The source branch for this change isregression/useIdleConnection, and it targets thedevelopbranch.